Issue 165188: Use base::WindowImpl instead of CWindowImpl to reduce dependencies on ATL....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 165188: Use base::WindowImpl instead of CWindowImpl to reduce dependencies on ATL.... (Closed)

Created:
11 years, 4 months ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
Mike Belshe, Peter Kasting

CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Use base::WindowImpl instead of CWindowImpl to reduce dependencies on ATL. BUG=5022 TEST=test_shell_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22864

Patch Set 1 #

Total comments: 1

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -14 lines)			Patch
M	base/window_impl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/window_impl.cc	View	1 chunk	+12 lines, -2 lines	0 comments	Download
M	webkit/tools/test_shell/foreground_helper.h	View	5 chunks	+18 lines, -11 lines	1 comment	Download
M	webkit/tools/test_shell/test_shell.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

11 years, 4 months ago (2009-08-08 00:33:49 UTC) #3

Forgot to publish my nit.

http://codereview.chromium.org/165188/diff/1/4
File webkit/tools/test_shell/foreground_helper.h (right):

http://codereview.chromium.org/165188/diff/1/4#newcode8
Line 8: #include <atlcrack.h>
Nit: Don't think you need this

Expand Messages | Collapse Messages