Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 165183003: Remove unused guards from config.h (Closed)

Created:
6 years, 10 months ago by lgombos
Modified:
6 years, 10 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

HAVE(MMAP), HAVE(VASPRINTF) and HAVE(DISPATCH_H) guards are no longer used, we should remove them. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167154

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M Source/config.h View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
lgombos
The code used these guards are all removed - we should remove the guards themselves ...
6 years, 10 months ago (2014-02-14 04:29:57 UTC) #1
eseidel
lgtm
6 years, 10 months ago (2014-02-14 04:31:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/165183003/1
6 years, 10 months ago (2014-02-14 04:31:45 UTC) #3
commit-bot: I haz the power
6 years, 10 months ago (2014-02-14 05:43:26 UTC) #4
Message was sent while issue was closed.
Change committed as 167154

Powered by Google App Engine
This is Rietveld 408576698