Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 165180: Merge 22087 - Missing buffered attribute for <video>/<audio>... (Closed)

Created:
11 years, 4 months ago by laforge
Modified:
9 years, 7 months ago
Reviewers:
hclam
CC:
chromium-reviews_googlegroups.com, fbarchard, Alpha Left Google, kylep, awong, brettw, scherkus (not reviewing)
Visibility:
Public.

Description

Merge 22087 - Missing buffered attribute for <video>/<audio> BUG=16056 TEST=LayoutTests/media/videobuffered.html The current implementation of the buffered attribute for <video> and <audio> is broken. There are several problems around this attribute: 1. We don't have any caching on disk, so we only keep a recent range of bytes close to current playback position. 2. WebKit reports buffered as one range (0, max_time_buffered). But we only cache a short partial range which doesn't start with 0. The correct implementation is a list of ranges buffered. But this has to go into WebKit first. 3. We don't have an accurate mapping between byte offset < > timestamp. So the current implementation is to lie about what we have buffered. We always say we have buffered everything before the current download position. And we only report one range. The calculation of time is also based on scaling the duration with current buffered bytes. Review URL: http://codereview.chromium.org/160300 TBR=hclam@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22822

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -2 lines) Patch
MM media/base/mock_filters.h View 1 chunk +12 lines, -0 lines 0 comments Download
MM media/base/pipeline_impl.cc View 1 chunk +16 lines, -1 line 0 comments Download
MM media/base/pipeline_impl_unittest.cc View 3 chunks +36 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
laforge
11 years, 4 months ago (2009-08-07 23:08:13 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698