Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 165176: Merge 21999 - BufferedDataSource to support server without range request supp... (Closed)

Created:
11 years, 4 months ago by laforge
Modified:
9 years, 7 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews_googlegroups.com, fbarchard, kylep, awong, darin (slow to review), brettw, scherkus (not reviewing)
Visibility:
Public.

Description

Merge 21999 - BufferedDataSource to support server without range request support This patch will enable BufferedDataSource to support servers with no range request support. It will start a probe request of 1 byte size besides the regular request. If the server does not support range request, we will turn on the is_streamed flag of FFmpeg and will not do any seeking. BUG=17628 TEST=test_shell_tests gtest_filter=BufferedDataSource.* Review URL: http://codereview.chromium.org/160076 TBR=hclam@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22812

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+434 lines, -187 lines) Patch
MM media/base/filter_host.h View 1 chunk +3 lines, -0 lines 0 comments Download
MM media/base/filters.h View 1 chunk +3 lines, -2 lines 0 comments Download
MM media/base/mock_filter_host.h View 1 chunk +1 line, -0 lines 0 comments Download
MM media/base/mock_filters.h View 1 chunk +1 line, -1 line 0 comments Download
MM media/base/pipeline.h View 1 chunk +4 lines, -0 lines 0 comments Download
MM media/base/pipeline_impl.h View 3 chunks +6 lines, -0 lines 0 comments Download
MM media/base/pipeline_impl.cc View 3 chunks +12 lines, -0 lines 0 comments Download
MM media/filters/ffmpeg_demuxer.h View 1 chunk +1 line, -1 line 0 comments Download
MM media/filters/ffmpeg_demuxer.cc View 1 chunk +4 lines, -2 lines 0 comments Download
MM media/filters/ffmpeg_demuxer_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
MM media/filters/ffmpeg_glue.h View 1 chunk +1 line, -1 line 0 comments Download
MM media/filters/ffmpeg_glue.cc View 1 chunk +1 line, -1 line 0 comments Download
MM media/filters/ffmpeg_glue_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
MM media/filters/file_data_source.h View 1 chunk +1 line, -1 line 0 comments Download
MM media/filters/file_data_source.cc View 1 chunk +2 lines, -3 lines 0 comments Download
MM webkit/api/public/WebMediaPlayer.h View 2 chunks +10 lines, -0 lines 0 comments Download
MM webkit/api/src/WebMediaPlayerClientImpl.h View 1 chunk +2 lines, -0 lines 0 comments Download
MM webkit/api/src/WebMediaPlayerClientImpl.cpp View 1 chunk +28 lines, -0 lines 0 comments Download
MM webkit/glue/media/buffered_data_source.h View 9 chunks +53 lines, -13 lines 0 comments Download
MM webkit/glue/media/buffered_data_source.cc View 20 chunks +143 lines, -102 lines 0 comments Download
MM webkit/glue/media/buffered_data_source_unittest.cc View 17 chunks +119 lines, -41 lines 0 comments Download
MM webkit/glue/media/simple_data_source.h View 1 chunk +1 line, -1 line 0 comments Download
MM webkit/glue/media/simple_data_source.cc View 1 chunk +2 lines, -2 lines 0 comments Download
MM webkit/glue/webmediaplayer_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
MM webkit/glue/webmediaplayer_impl.cc View 4 chunks +25 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
laforge
11 years, 4 months ago (2009-08-07 22:44:18 UTC) #1
Alpha Left Google
11 years, 4 months ago (2009-08-07 22:44:57 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698