Issue 165173: Merge 21946 - Move window to workarea origin if it is completely offscreen....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 165173: Merge 21946 - Move window to workarea origin if it is completely offscreen.... (Closed)

Created:
11 years, 4 months ago by laforge

Modified:
9 years, 7 months ago

Reviewers:
Yuzo

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/branches/195/src/

Visibility:
Public.

Description

Merge 21946 - Move window to workarea origin if it is completely offscreen. BUG=17822 TEST=Use multiple monitors. Start Chrome, move the window to a nonprimary monitor, and exit Chrome. Disconnect or disable the monitor and start Chrome again. Chrome should appear at the origin of a remaining monitor. Also try chaning the resolution of the nonprimary monitor. As far as the window fits within the monitor, it should be shown asis. If not, it is moved to the origin and resized, if necessary. Review URL: http://codereview.chromium.org/160246 TBR=yuzo@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22808

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+244 lines, -88 lines)			Patch
MM	chrome/browser/gtk/browser_window_gtk.cc	View	3 chunks	+12 lines, -0 lines	0 comments	Download
MM	chrome/browser/views/chrome_views_delegate.cc	View	2 chunks	+11 lines, -0 lines	0 comments	Download
MM	chrome/browser/window_sizer.h	View	2 chunks	+7 lines, -1 line	0 comments	Download
MM	chrome/browser/window_sizer.cc	View	5 chunks	+47 lines, -5 lines	0 comments	Download
MM	chrome/browser/window_sizer_unittest.cc	View	39 chunks	+167 lines, -82 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM. Thank you.

Expand Messages | Collapse Messages