Issue 165172: Fix for bookmark bar text not being correct in subsequent Windows. I believe ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 165172: Fix for bookmark bar text not being correct in subsequent Windows. I believe ... (Closed)

Created:
11 years, 4 months ago by Glen Murphy

Modified:
9 years, 5 months ago

Reviewers:
Miranda Callahan

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix for bookmark bar text not being correct in subsequent Windows. I believe this bug was masked by how long bookmarks take to create in the primary window (as the bookmark system is loaded late) BUG=18550 TEST=Install a theme with custom colors for bookmark bar text, then open a new window and verify that the bookmark bar text is themed correctly. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22840

Patch Set 1 #

Total comments: 1

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -5 lines)			Patch
	M	chrome/browser/views/bookmark_bar_view.cc	View		1 chunk	+12 lines, -5 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Miranda Callahan

LG with ei->ie nit! On 2009/08/07 22:30:51, Glen Murphy wrote: >

11 years, 4 months ago (2009-08-07 22:35:32 UTC) #2

Miranda Callahan

11 years, 4 months ago (2009-08-07 22:35:46 UTC) #3

http://codereview.chromium.org/165172/diff/1/2
File chrome/browser/views/bookmark_bar_view.cc (right):

http://codereview.chromium.org/165172/diff/1/2#newcode571
Line 571: // We may get inserted into a heirarchy with a profile - this
typically
nit: hierarchy

Expand Messages | Collapse Messages