third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp - Issue 1651703002: More explicit LayoutUnit conversions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 1651703002: More explicit LayoutUnit conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@evenMoarConstructors

Patch Set: Traits vs Properties vs Pandas Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

index 9bf71bbcae90e5204f6ec7d06d507be2807ebba6..3a188a47a028e227f79a2b2afb899fb2b23fcd3c 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

@@ -902,14 +902,14 @@ IntRect PaintLayerScrollableArea::rectForVerticalScrollbar(const IntRect& border

borderBoxRect.height() - (box().borderTop() + box().borderBottom()) - scrollCorner.height());

}

-LayoutUnit PaintLayerScrollableArea::verticalScrollbarStart(int minX, int maxX) const

+int PaintLayerScrollableArea::verticalScrollbarStart(int minX, int maxX) const

{

if (box().shouldPlaceBlockDirectionScrollbarOnLogicalLeft())

return minX + box().borderLeft();

return maxX - box().borderRight() - verticalScrollbar()->width();

}

-LayoutUnit PaintLayerScrollableArea::horizontalScrollbarStart(int minX) const

+int PaintLayerScrollableArea::horizontalScrollbarStart(int minX) const

{

int x = minX + box().borderLeft();

if (box().shouldPlaceBlockDirectionScrollbarOnLogicalLeft())