third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.cpp - Issue 1651703002: More explicit LayoutUnit conversions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.cpp

Issue 1651703002: More explicit LayoutUnit conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@evenMoarConstructors

Patch Set: Traits vs Properties vs Pandas Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/shapes/BoxShapeTest.cpp ('k') | third_party/WebKit/Source/core/page/SpatialNavigation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.cpp b/third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.cpp

index d1f1b59848fb09c0bbfc2b4ededbd253366982fc..5a4882f3de788877f2768e5d7d5bfb95d9c0e3e2 100644

--- a/third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/line/SVGRootInlineBox.cpp

@@ -119,11 +119,11 @@ void SVGRootInlineBox::layoutRootBox(const LayoutRect& childRect)

}

// Position ourselves.

- setX(0);

- setY(0);

+ setX(LayoutUnit());

+ setY(LayoutUnit());

setLogicalWidth(childRect.width());

setLogicalHeight(childRect.height());

- setLineTopBottomPositions(0, boundingRect.height(), 0, boundingRect.height());

+ setLineTopBottomPositions(LayoutUnit(), boundingRect.height(), LayoutUnit(), boundingRect.height());

}

InlineBox* SVGRootInlineBox::closestLeafChildForPosition(const LayoutPoint& point)