third_party/WebKit/Source/core/layout/LayoutTableRow.cpp - Issue 1651703002: More explicit LayoutUnit conversions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableRow.cpp

Issue 1651703002: More explicit LayoutUnit conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@evenMoarConstructors

Patch Set: Traits vs Properties vs Pandas Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutTableRow.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp b/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp

index 0a133677416ef06d2b951ddea4e42ca56eec54e9..3280fa909128c24ec28b6051ea503d7f296c3507 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp

@@ -250,7 +250,7 @@ void LayoutTableRow::addOverflowFromCell(const LayoutTableCell* cell)

// the visual overflow should be determined in the coordinate system of

// the row, that's why we shift it below.

LayoutUnit cellOffsetLogicalTopDifference = cell->location().y() - location().y();

- cellVisualOverflowRect.move(0, cellOffsetLogicalTopDifference);

+ cellVisualOverflowRect.move(LayoutUnit(), cellOffsetLogicalTopDifference);

addVisualOverflow(cellVisualOverflowRect);

}