third_party/WebKit/Source/core/layout/LayoutListBox.cpp - Issue 1651703002: More explicit LayoutUnit conversions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutListBox.cpp

Issue 1651703002: More explicit LayoutUnit conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@evenMoarConstructors

Patch Set: Traits vs Properties vs Pandas Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutListBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutListBox.cpp b/third_party/WebKit/Source/core/layout/LayoutListBox.cpp

index 614957fa3d58c88aac9735f2d26abd772656979d..7d4a09b205f2bd9fce82466576bdc6bfb04c36a1 100644

--- a/third_party/WebKit/Source/core/layout/LayoutListBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutListBox.cpp

@@ -96,14 +96,14 @@ unsigned LayoutListBox::size() const

LayoutUnit LayoutListBox::defaultItemHeight() const

{

- return style()->fontMetrics().height() + defaultPaddingBottom;

+ return LayoutUnit(style()->fontMetrics().height() + defaultPaddingBottom);

}

LayoutUnit LayoutListBox::itemHeight() const

{

HTMLSelectElement* select = selectElement();

if (!select)

- return 0;

+ return LayoutUnit();

Element* baseItem = ElementTraversal::firstChild(*select);

if (!baseItem)

return defaultItemHeight();