Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: third_party/WebKit/Source/modules/accessibility/AXObject.cpp

Issue 1651703002: More explicit LayoutUnit conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@evenMoarConstructors
Patch Set: Traits vs Properties vs Pandas Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2009, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2008, 2009, 2011 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 1544 matching lines...) Expand 10 before | Expand all | Expand 10 after
1555 int lineCount = -1; 1555 int lineCount = -1;
1556 VisiblePosition currentPosition = position; 1556 VisiblePosition currentPosition = position;
1557 VisiblePosition previousPosition; 1557 VisiblePosition previousPosition;
1558 1558
1559 // move up until we get to the top 1559 // move up until we get to the top
1560 // FIXME: This only takes us to the top of the rootEditableElement, not the top of the 1560 // FIXME: This only takes us to the top of the rootEditableElement, not the top of the
1561 // top document. 1561 // top document.
1562 do { 1562 do {
1563 previousPosition = currentPosition; 1563 previousPosition = currentPosition;
1564 currentPosition = previousLinePosition( 1564 currentPosition = previousLinePosition(
1565 currentPosition, 0, HasEditableAXRole); 1565 currentPosition, LayoutUnit(), HasEditableAXRole);
1566 ++lineCount; 1566 ++lineCount;
1567 } while (currentPosition.isNotNull() 1567 } while (currentPosition.isNotNull()
1568 && !inSameLine(currentPosition, previousPosition)); 1568 && !inSameLine(currentPosition, previousPosition));
1569 1569
1570 return lineCount; 1570 return lineCount;
1571 } 1571 }
1572 1572
1573 bool AXObject::isARIAControl(AccessibilityRole ariaRole) 1573 bool AXObject::isARIAControl(AccessibilityRole ariaRole)
1574 { 1574 {
1575 return isARIAInput(ariaRole) || ariaRole == ButtonRole 1575 return isARIAInput(ariaRole) || ariaRole == ButtonRole
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
1701 1701
1702 DEFINE_TRACE(AXObject) 1702 DEFINE_TRACE(AXObject)
1703 { 1703 {
1704 visitor->trace(m_children); 1704 visitor->trace(m_children);
1705 visitor->trace(m_parent); 1705 visitor->trace(m_parent);
1706 visitor->trace(m_cachedLiveRegionRoot); 1706 visitor->trace(m_cachedLiveRegionRoot);
1707 visitor->trace(m_axObjectCache); 1707 visitor->trace(m_axObjectCache);
1708 } 1708 }
1709 1709
1710 } // namespace blink 1710 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698