Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 1651703002: More explicit LayoutUnit conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@evenMoarConstructors
Patch Set: Traits vs Properties vs Pandas Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 2341 matching lines...) Expand 10 before | Expand all | Expand 10 after
2352 referencePoint.move(currentOffset); 2352 referencePoint.move(currentOffset);
2353 currContainer = nextContainer; 2353 currContainer = nextContainer;
2354 } while (currContainer != ancestorContainer); 2354 } while (currContainer != ancestorContainer);
2355 2355
2356 return offset; 2356 return offset;
2357 } 2357 }
2358 2358
2359 LayoutRect LayoutObject::localCaretRect(InlineBox*, int, LayoutUnit* extraWidthT oEndOfLine) 2359 LayoutRect LayoutObject::localCaretRect(InlineBox*, int, LayoutUnit* extraWidthT oEndOfLine)
2360 { 2360 {
2361 if (extraWidthToEndOfLine) 2361 if (extraWidthToEndOfLine)
2362 *extraWidthToEndOfLine = 0; 2362 *extraWidthToEndOfLine = LayoutUnit();
2363 2363
2364 return LayoutRect(); 2364 return LayoutRect();
2365 } 2365 }
2366 2366
2367 void LayoutObject::computeLayerHitTestRects(LayerHitTestRects& layerRects) const 2367 void LayoutObject::computeLayerHitTestRects(LayerHitTestRects& layerRects) const
2368 { 2368 {
2369 // Figure out what layer our container is in. Any offset (or new layer) for this 2369 // Figure out what layer our container is in. Any offset (or new layer) for this
2370 // layoutObject within it's container will be applied in addLayerHitTestRect s. 2370 // layoutObject within it's container will be applied in addLayerHitTestRect s.
2371 LayoutPoint layerOffset; 2371 LayoutPoint layerOffset;
2372 const PaintLayer* currentLayer = nullptr; 2372 const PaintLayer* currentLayer = nullptr;
(...skipping 1191 matching lines...) Expand 10 before | Expand all | Expand 10 after
3564 const blink::LayoutObject* root = object1; 3564 const blink::LayoutObject* root = object1;
3565 while (root->parent()) 3565 while (root->parent())
3566 root = root->parent(); 3566 root = root->parent();
3567 root->showLayoutTreeAndMark(object1, "*", object2, "-", 0); 3567 root->showLayoutTreeAndMark(object1, "*", object2, "-", 0);
3568 } else { 3568 } else {
3569 fprintf(stderr, "Cannot showLayoutTree. Root is (nil)\n"); 3569 fprintf(stderr, "Cannot showLayoutTree. Root is (nil)\n");
3570 } 3570 }
3571 } 3571 }
3572 3572
3573 #endif 3573 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698