Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 165168: Test startup of new tab page with a complex theme.... (Closed)

Created:
11 years, 4 months ago by Miranda Callahan
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Test startup of new tab page with a complex theme. BUG= http://crbug.com/18767 TEST= none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22925

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 6

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Total comments: 6

Patch Set 8 : '' #

Patch Set 9 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -21 lines) Patch
M chrome/test/startup/feature_startup_test.cc View 1 2 3 4 5 6 7 3 chunks +14 lines, -15 lines 0 comments Download
M chrome/test/startup/startup_test.cc View 5 6 7 3 chunks +19 lines, -6 lines 0 comments Download
M chrome/test/ui/ui_test.h View 2 3 4 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/test/ui/ui_test.cc View 5 6 7 8 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Miranda Callahan
Nicolas, we had discussed making sure this gets picked up by the bots and displayed ...
11 years, 4 months ago (2009-08-07 22:55:37 UTC) #1
Nicolas Sylvain
http://codereview.chromium.org/165168/diff/9/1010 File chrome/test/startup/feature_startup_test.cc (right): http://codereview.chromium.org/165168/diff/9/1010#newcode60 Line 60: int profile_type) { align with const above? http://codereview.chromium.org/165168/diff/9/1010#newcode124 ...
11 years, 4 months ago (2009-08-07 23:12:14 UTC) #2
Miranda Callahan
All right -- made the test cold, and added a test to startup_test.cc that tests ...
11 years, 4 months ago (2009-08-09 20:34:34 UTC) #3
Nicolas Sylvain
http://codereview.chromium.org/165168/diff/1024/26 File chrome/test/startup/feature_startup_test.cc (right): http://codereview.chromium.org/165168/diff/1024/26#newcode31 Line 31: else why not "else if COMPLEX_THEME ... else ...
11 years, 4 months ago (2009-08-10 16:42:48 UTC) #4
Miranda Callahan
http://codereview.chromium.org/165168/diff/1024/26 File chrome/test/startup/feature_startup_test.cc (right): http://codereview.chromium.org/165168/diff/1024/26#newcode31 Line 31: else On 2009/08/10 16:42:48, Nicolas Sylvain wrote: > ...
11 years, 4 months ago (2009-08-10 17:12:43 UTC) #5
Nicolas Sylvain
11 years, 4 months ago (2009-08-10 17:41:36 UTC) #6
LGTM!

Powered by Google App Engine
This is Rietveld 408576698