Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Issue 1651643002: Roll clang 257955:259395 (Closed)

Created:
4 years, 10 months ago by Nico
Modified:
4 years, 10 months ago
CC:
chromium-reviews, yunlian, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org, flim-chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll clang 257955:259395 Includes codegen fix for volatile 64-bit stores in 32-bit builds on Windows. Also brings in -Wexpansion-to-defined, and a stricter -Wconstant-conversion. (Unfortunately, an opus roll brought in a Wexpansion-to-defined violation 2 hours ago, so suppress the warning in that target until it's fixed upstream -- hopefully soon.) BUG=580241 R=hans@chromium.org TBR=henrika Committed: https://chromium.googlesource.com/chromium/src/+/007d05dfe4d2c0bf9ce5e1b4c2ead706728e94c0

Patch Set 1 #

Patch Set 2 : 259395 #

Patch Set 3 : flags #

Patch Set 4 : libwebp #

Patch Set 5 : hey its c #

Patch Set 6 : dynamic annotations #

Patch Set 7 : cros1 #

Patch Set 8 : rebase #

Patch Set 9 : opuuuuuuus #

Patch Set 10 : opuuuuuuuuuuuuuuuus #

Patch Set 11 : rebase #

Patch Set 12 : opuuuuuuuuhuhuhuhuhuhuhus #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -17 lines) Patch
M build/common.gypi View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -5 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/opus/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +13 lines, -1 line 0 comments Download
M third_party/opus/opus.gyp View 1 2 3 4 5 6 7 8 1 chunk +6 lines, -0 lines 0 comments Download
M tools/clang/scripts/update.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (11 generated)
Nico
hans: ptal tbr henrika for opus change
4 years, 10 months ago (2016-02-02 19:42:14 UTC) #7
hans
Description says 259359 but update.py says 259395. LGTM besides that
4 years, 10 months ago (2016-02-02 19:49:00 UTC) #8
Nico
thanks, fixed
4 years, 10 months ago (2016-02-02 19:50:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1651643002/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1651643002/220001
4 years, 10 months ago (2016-02-02 21:29:26 UTC) #13
commit-bot: I haz the power
Patchset 12 (id:??) landed as https://crrev.com/007d05dfe4d2c0bf9ce5e1b4c2ead706728e94c0 Cr-Commit-Position: refs/heads/master@{#373052}
4 years, 10 months ago (2016-02-02 22:10:29 UTC) #15
Nico
Committed patchset #12 (id:220001) manually as 007d05dfe4d2c0bf9ce5e1b4c2ead706728e94c0 (presubmit successful).
4 years, 10 months ago (2016-02-02 22:11:10 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/173953)
4 years, 10 months ago (2016-02-02 22:16:42 UTC) #18
henrika (OOO until Aug 14)
4 years, 10 months ago (2016-02-03 09:09:40 UTC) #19
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698