content/DEPS - Issue 16516003: SSLTCP (pseudo-SSL with fake handshake and unencrypted data) support for p2p socket.

Side by Side Diff: content/DEPS

Issue 16516003: SSLTCP (pseudo-SSL with fake handshake and unencrypted data) support for p2p socket. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 # Do NOT add chrome or components to the list below. We shouldn't be	1 # Do NOT add chrome or components to the list below. We shouldn't be

2 # including files from src/chrome or src/components in src/content.	2 # including files from src/chrome or src/components in src/content.

3 include_rules = [	3 include_rules = [

4 # The subdirectories in content/ will manually allow their own include	4 # The subdirectories in content/ will manually allow their own include

5 # directories in content/ so we disallow all of them.	5 # directories in content/ so we disallow all of them.

6 "-content",	6 "-content",

7 "+content/common",	7 "+content/common",

8 "+content/port/common",	8 "+content/port/common",

9 "+content/public/common",	9 "+content/public/common",

10 "+content/public/test",	10 "+content/public/test",

(...skipping 37 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
48	48

49 # Don't allow inclusion of these other libs we shouldn't be calling directly.	49 # Don't allow inclusion of these other libs we shouldn't be calling directly.

50 "-v8",	50 "-v8",

51 "-tools",	51 "-tools",

52	52

53 # Allow inclusion of third-party code:	53 # Allow inclusion of third-party code:

54 "+third_party/angle",	54 "+third_party/angle",

55 "+third_party/flac",	55 "+third_party/flac",

56 "+third_party/gpsd",	56 "+third_party/gpsd",

57 "+third_party/libjingle",	57 "+third_party/libjingle",

	58 "+jingle/glue",
	piman 2013/06/20 20:53:15 So far, jingle has only been called from the rende So far, jingle has only been called from the renderer process. I don't think we should blanket-allow jingle to be used everywhere in content, especially on the browser side. It looks like you only need a single class from there - which even looks like a test class, so I'm confused. If it really needs to be used in the browser, is there a way to move it to a place that doesn't require openning the floodgates? If not, can we make the DEPS as specific as possible (i.e. only that file, with a comment as to why)? Ronghua Wu (Left Chromium) 2013/06/20 21:05:28 content is already depends on libjingle, so we tho Show quoted text On 2013/06/20 20:53:15, piman wrote: > So far, jingle has only been called from the renderer process. I don't think we > should blanket-allow jingle to be used everywhere in content, especially on the > browser side. > It looks like you only need a single class from there - which even looks like a > test class, so I'm confused. > If it really needs to be used in the browser, is there a way to move it to a > place that doesn't require openning the floodgates? If not, can we make the DEPS > as specific as possible (i.e. only that file, with a comment as to why)? content is already depends on libjingle, so we thought it's fine to add jingle/glue which is just a thin layer on top of libjingle. What about add a DEPS to content/browser/renderer_host/p2p/, where jingle is used.
58 "+third_party/mozilla",	59 "+third_party/mozilla",

59 "+third_party/npapi/bindings",	60 "+third_party/npapi/bindings",

60 "+third_party/skia",	61 "+third_party/skia",

61 "+third_party/sqlite",	62 "+third_party/sqlite",

62 "+third_party/tcmalloc",	63 "+third_party/tcmalloc",

63 "+third_party/khronos",	64 "+third_party/khronos",

64 "+third_party/webrtc",	65 "+third_party/webrtc",

65 "+third_party/zlib/google",	66 "+third_party/zlib/google",

66 "+third_party/WebKit/public/platform",	67 "+third_party/WebKit/public/platform",

67 "+third_party/WebKit/Source/WebKit/chromium",	68 "+third_party/WebKit/Source/WebKit/chromium",

(...skipping 21 matching lines...) Expand all Loading...
89 # explicit.	90 # explicit.

90 "-ui/views",	91 "-ui/views",

91	92

92 "+webkit",	93 "+webkit",

93 "-webkit/dom_storage",	94 "-webkit/dom_storage",

94 "+webkit/dom_storage/dom_storage_types.h",	95 "+webkit/dom_storage/dom_storage_types.h",

95	96

96 # For generated JNI includes.	97 # For generated JNI includes.

97 "+jni",	98 "+jni",

98 ]	99 ]

OLD	NEW

« no previous file with comments | « no previous file | content/browser/renderer_host/p2p/socket_host.cc » ('j') | content/browser/renderer_host/p2p/socket_host_tcp.cc » ('J')