Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 16516: Add offset when building glyphpage tree nodes. (Closed)

Created:
11 years, 11 months ago by jungshik at Google
Modified:
9 years, 7 months ago
Reviewers:
eroman
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add offset when building glyphpage tree nodes. This will be followed right away by http://codereview.chromium.org/16525. BUG=6021 TEST=LayoutTests/fast/css/font-face-unicode-range.html LayoutTests/fast/css/font-face-implicit-local-font.html Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7607

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -31 lines) Patch
M third_party/WebKit/WebCore/platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp View 1 2 7 chunks +38 lines, -31 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jungshik at Google
11 years, 11 months ago (2009-01-06 01:29:20 UTC) #1
eroman
LGTM http://codereview.chromium.org/16516/diff/205/4 File third_party/WebKit/WebCore/platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp (right): http://codereview.chromium.org/16516/diff/205/4#newcode62 Line 62: // can use the standard Windows GDI ...
11 years, 11 months ago (2009-01-06 01:58:50 UTC) #2
jungshik at Google
11 years, 11 months ago (2009-01-06 20:34:15 UTC) #3
thanks for the review. I addressed your concerns and am committing now.

On 2009/01/06 01:58:50, eroman wrote:
> LGTM
> 
> http://codereview.chromium.org/16516/diff/205/4
> File
>
third_party/WebKit/WebCore/platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp
> (right):
> 
> http://codereview.chromium.org/16516/diff/205/4#newcode62
> Line 62: // can use the standard Windows GDI functions here. The input buffer
> size is
> Can you update the comment (buffer size is no longer assumed GlyphPage::size).
> 
> http://codereview.chromium.org/16516/diff/205/4#newcode177
> Line 177: // For non-BMP characters, each is two words (UTF-16) and the input
> buffer size
> Does this comment about buffer size still hold? (If not please remove it).

Powered by Google App Engine
This is Rietveld 408576698