NaCl cleanup: Remove now-unneeded initialisation of NaCl libraries

NaCl cleanup: Remove now-unneeded initialisation of NaCl libraries (2nd try)

The renderer now no longer uses these NaCl libraries, so we don't need
to initialise them on startup in module_ppapi.cc.  This leaves
UrandomFD() unused, so we can remove it too.

This means that, on Linux, the chrome executable no longer pulls in
any code that uses thread-local (TLS) variables (those declared with
"__thread").  This means that it no longer references the function
__tls_get_addr() (or ___tls_get_addr() on i386), which is defined by
ld-linux.so with symbol version "GLIBC_2.3".  This means we must
update the symbol version dependency expectations in
chrome/installer/linux/rpm/expected_deps_*.

For example, nacl_log.c is one source file that uses __thread
variables on Linux, and that no longer gets linked into chrome now.

Before the change:

  $ objdump -x out/Release/chrome
  ...
    required from ld-linux-x86-64.so.2:
      0x09691a75 0x00 47 GLIBC_2.2.5
      0x0d696913 0x00 48 GLIBC_2.3
  ...
  $ nm -D out/Release/chrome | grep tls_get
                   U __tls_get_addr

After the change:

  $ objdump -x out/Release/chrome
  ...
    required from ld-linux-x86-64.so.2:
      0x09691a75 0x00 47 GLIBC_2.2.5
  ...
  $ nm -D out/Release/chrome | grep tls_get

This is a retry of https://codereview.chromium.org/1646733002/, which
got reverted because the symbol version expectations changed.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=2832
TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation)

Committed: https://crrev.com/deb5941331e83f0819b0cef08a8adaf9788dc167
Cr-Commit-Position: refs/heads/master@{#372437}

[Mark Seaborn, 2016-01-29 19:48:34]

Description was changed from

==========
NaCl cleanup: Remove now-unneeded initialisation of NaCl libraries
==========

to

==========
NaCl cleanup: Remove now-unneeded initialisation of NaCl libraries (2nd try)

The renderer now no longer uses these NaCl libraries, so we don't need
to initialise them on startup in module_ppapi.cc.  This leaves
UrandomFD() unused, so we can remove it too.

This means that, on Linux, the chrome executable no longer pulls in
any code that uses thread-local (TLS) variables (those declared with
"__thread").  This means that it no longer references the function
__tls_get_addr() (or ___tls_get_addr() on i386), which is defined by
ld-linux.so with symbol version "GLIBC_2.3".  This means we must
update the symbol version dependency expectations in
chrome/installer/linux/rpm/expected_deps_*.

For example, nacl_log.c is one source file that uses __thread
variables on Linux, and that no longer gets linked into chrome now.

Before the change:

  $ objdump -x out/Release/chrome
  ...
    required from ld-linux-x86-64.so.2:
      0x09691a75 0x00 47 GLIBC_2.2.5
      0x0d696913 0x00 48 GLIBC_2.3
  ...
  $ nm -D out/Release/chrome | grep tls_get
                   U __tls_get_addr

After the change:

  $ objdump -x out/Release/chrome
  ...
    required from ld-linux-x86-64.so.2:
      0x09691a75 0x00 47 GLIBC_2.2.5
  ...
  $ nm -D out/Release/chrome | grep tls_get

This is a retry of https://codereview.chromium.org/1646733002/, which
got reverted because the symbol version expectations changed.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=2832
TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation)
==========

[Mark Seaborn, 2016-01-29 19:48:40]

The CQ bit was checked by mseaborn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-29 19:49:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1651583002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1651583002/20001

[Mark Seaborn, 2016-01-29 20:12:25]

mseaborn@chromium.org changed reviewers:
+ bbudge@chromium.org, thestig@chromium.org

[Mark Seaborn, 2016-01-29 20:12:26]

+thestig for OWNERS sign-off on chrome/installer/linux/rpm/.

[bbudge, 2016-01-29 20:18:05]

Whew! still LGTM

[commit-bot: I haz the power, 2016-01-29 21:06:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-29 21:06:07]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-01-29 21:38:16]

lgtm

[Mark Seaborn, 2016-01-29 22:03:27]

The CQ bit was checked by mseaborn@chromium.org

[commit-bot: I haz the power, 2016-01-29 22:06:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1651583002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1651583002/20001

[commit-bot: I haz the power, 2016-01-29 22:15:15]

Description was changed from

==========
NaCl cleanup: Remove now-unneeded initialisation of NaCl libraries (2nd try)

The renderer now no longer uses these NaCl libraries, so we don't need
to initialise them on startup in module_ppapi.cc.  This leaves
UrandomFD() unused, so we can remove it too.

This means that, on Linux, the chrome executable no longer pulls in
any code that uses thread-local (TLS) variables (those declared with
"__thread").  This means that it no longer references the function
__tls_get_addr() (or ___tls_get_addr() on i386), which is defined by
ld-linux.so with symbol version "GLIBC_2.3".  This means we must
update the symbol version dependency expectations in
chrome/installer/linux/rpm/expected_deps_*.

For example, nacl_log.c is one source file that uses __thread
variables on Linux, and that no longer gets linked into chrome now.

Before the change:

  $ objdump -x out/Release/chrome
  ...
    required from ld-linux-x86-64.so.2:
      0x09691a75 0x00 47 GLIBC_2.2.5
      0x0d696913 0x00 48 GLIBC_2.3
  ...
  $ nm -D out/Release/chrome | grep tls_get
                   U __tls_get_addr

After the change:

  $ objdump -x out/Release/chrome
  ...
    required from ld-linux-x86-64.so.2:
      0x09691a75 0x00 47 GLIBC_2.2.5
  ...
  $ nm -D out/Release/chrome | grep tls_get

This is a retry of https://codereview.chromium.org/1646733002/, which
got reverted because the symbol version expectations changed.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=2832
TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation)
==========

to

==========
NaCl cleanup: Remove now-unneeded initialisation of NaCl libraries (2nd try)

The renderer now no longer uses these NaCl libraries, so we don't need
to initialise them on startup in module_ppapi.cc.  This leaves
UrandomFD() unused, so we can remove it too.

This means that, on Linux, the chrome executable no longer pulls in
any code that uses thread-local (TLS) variables (those declared with
"__thread").  This means that it no longer references the function
__tls_get_addr() (or ___tls_get_addr() on i386), which is defined by
ld-linux.so with symbol version "GLIBC_2.3".  This means we must
update the symbol version dependency expectations in
chrome/installer/linux/rpm/expected_deps_*.

For example, nacl_log.c is one source file that uses __thread
variables on Linux, and that no longer gets linked into chrome now.

Before the change:

  $ objdump -x out/Release/chrome
  ...
    required from ld-linux-x86-64.so.2:
      0x09691a75 0x00 47 GLIBC_2.2.5
      0x0d696913 0x00 48 GLIBC_2.3
  ...
  $ nm -D out/Release/chrome | grep tls_get
                   U __tls_get_addr

After the change:

  $ objdump -x out/Release/chrome
  ...
    required from ld-linux-x86-64.so.2:
      0x09691a75 0x00 47 GLIBC_2.2.5
  ...
  $ nm -D out/Release/chrome | grep tls_get

This is a retry of https://codereview.chromium.org/1646733002/, which
got reverted because the symbol version expectations changed.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=2832
TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation)
==========

[commit-bot: I haz the power, 2016-01-29 22:15:16]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-29 22:16:56]

Description was changed from

==========
NaCl cleanup: Remove now-unneeded initialisation of NaCl libraries (2nd try)

The renderer now no longer uses these NaCl libraries, so we don't need
to initialise them on startup in module_ppapi.cc.  This leaves
UrandomFD() unused, so we can remove it too.

This means that, on Linux, the chrome executable no longer pulls in
any code that uses thread-local (TLS) variables (those declared with
"__thread").  This means that it no longer references the function
__tls_get_addr() (or ___tls_get_addr() on i386), which is defined by
ld-linux.so with symbol version "GLIBC_2.3".  This means we must
update the symbol version dependency expectations in
chrome/installer/linux/rpm/expected_deps_*.

For example, nacl_log.c is one source file that uses __thread
variables on Linux, and that no longer gets linked into chrome now.

Before the change:

  $ objdump -x out/Release/chrome
  ...
    required from ld-linux-x86-64.so.2:
      0x09691a75 0x00 47 GLIBC_2.2.5
      0x0d696913 0x00 48 GLIBC_2.3
  ...
  $ nm -D out/Release/chrome | grep tls_get
                   U __tls_get_addr

After the change:

  $ objdump -x out/Release/chrome
  ...
    required from ld-linux-x86-64.so.2:
      0x09691a75 0x00 47 GLIBC_2.2.5
  ...
  $ nm -D out/Release/chrome | grep tls_get

This is a retry of https://codereview.chromium.org/1646733002/, which
got reverted because the symbol version expectations changed.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=2832
TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation)
==========

to

==========
NaCl cleanup: Remove now-unneeded initialisation of NaCl libraries (2nd try)

The renderer now no longer uses these NaCl libraries, so we don't need
to initialise them on startup in module_ppapi.cc.  This leaves
UrandomFD() unused, so we can remove it too.

This means that, on Linux, the chrome executable no longer pulls in
any code that uses thread-local (TLS) variables (those declared with
"__thread").  This means that it no longer references the function
__tls_get_addr() (or ___tls_get_addr() on i386), which is defined by
ld-linux.so with symbol version "GLIBC_2.3".  This means we must
update the symbol version dependency expectations in
chrome/installer/linux/rpm/expected_deps_*.

For example, nacl_log.c is one source file that uses __thread
variables on Linux, and that no longer gets linked into chrome now.

Before the change:

  $ objdump -x out/Release/chrome
  ...
    required from ld-linux-x86-64.so.2:
      0x09691a75 0x00 47 GLIBC_2.2.5
      0x0d696913 0x00 48 GLIBC_2.3
  ...
  $ nm -D out/Release/chrome | grep tls_get
                   U __tls_get_addr

After the change:

  $ objdump -x out/Release/chrome
  ...
    required from ld-linux-x86-64.so.2:
      0x09691a75 0x00 47 GLIBC_2.2.5
  ...
  $ nm -D out/Release/chrome | grep tls_get

This is a retry of https://codereview.chromium.org/1646733002/, which
got reverted because the symbol version expectations changed.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=2832
TEST=e.g. NaClBrowserTestPnacl.PPAPICore (tests PNaCl translation)

Committed: https://crrev.com/deb5941331e83f0819b0cef08a8adaf9788dc167
Cr-Commit-Position: refs/heads/master@{#372437}
==========

[commit-bot: I haz the power, 2016-01-29 22:16:57]

Patchset 2 (id:??) landed as
https://crrev.com/deb5941331e83f0819b0cef08a8adaf9788dc167
Cr-Commit-Position: refs/heads/master@{#372437}

[joedow, 2016-01-29 23:42:08]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1656463002/ by joedow@chromium.org.

The reason for reverting is: Reverting due to build break on the official
waterfall.

Yesterday the x86 builder was broken, today it is the x64 version:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux...

error message:
> ld-linux-x86-64.so.2(GLIBC_2.3)(64bit)

ERROR: Shared library dependencies changed!
If this is intentional, please update:
chrome/installer/linux/rpm/expected_deps_i386
chrome/installer/linux/rpm/expected_deps_x86_64

Perhaps on the i386 deps need updating?.