Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/new_new_tab.js

Issue 165147: Merge 22320 - Fix issue where the favicon was not shown on the NNTP... (Closed) Base URL: svn://chrome-svn/chrome/branches/195/src/
Patch Set: Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/new_new_tab.js
===================================================================
--- chrome/browser/resources/new_new_tab.js (revision 22755)
+++ chrome/browser/resources/new_new_tab.js (working copy)
@@ -256,7 +256,7 @@
var titleDiv = t.querySelector('.title > div');
titleDiv.xtitle = titleDiv.textContent = d.title;
var faviconUrl = d.faviconUrl || 'chrome://favicon/' + d.url;
- titleDiv.style.backgroundImage = encodeURI(url);
+ titleDiv.style.backgroundImage = url(faviconUrl);
titleDiv.dir = d.direction;
}
}
Property changes on: chrome\browser\resources\new_new_tab.js
___________________________________________________________________
Modified: svn:mergeinfo
Merged /trunk/src/chrome/browser/resources/new_new_tab.js:r22320
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698