Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1651453002: Give InputMethodWin an out-of-line destructor. (Closed)

Created:
4 years, 10 months ago by Nico
Modified:
4 years, 10 months ago
Reviewers:
Azure Wei
CC:
chromium-reviews, nona+watch_chromium.org, James Su, shuchen+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Give InputMethodWin an out-of-line destructor. Fixes ..\..\ui/base/ime/input_method_win.h(20,1) : error: [chromium-style] Complex class/struct needs an explicit out-of-line destructor. class UI_BASE_IME_EXPORT InputMethodWin : public InputMethodBase { ^ BUG=82385 TBR=azurewei Committed: https://crrev.com/7163128dcbf6808756a2715d009e59c3c608ca1f Cr-Commit-Position: refs/heads/master@{#372356}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ui/base/ime/input_method_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/ime/input_method_win.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Nico
4 years, 10 months ago (2016-01-29 15:42:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1651453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1651453002/1
4 years, 10 months ago (2016-01-29 15:43:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-29 16:34:49 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 16:35:59 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7163128dcbf6808756a2715d009e59c3c608ca1f
Cr-Commit-Position: refs/heads/master@{#372356}

Powered by Google App Engine
This is Rietveld 408576698