Issue 165142: Re-enable remaining FTP unit tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 165142: Re-enable remaining FTP unit tests. (Closed)

Created:
11 years, 4 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
wtc

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Re-enable remaining FTP unit tests. Also, use NotifyDone in URLRequestNewFtpJob instead of NotifyStartError. This way is_pending in URLRequest is correctly reset to false. TEST=Covered by net_unittests. http://crbug.com/18036 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22752

Patch Set 1 #

Total comments: 1

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -5 lines)			Patch
	M	net/url_request/url_request_new_ftp_job.cc	View		1 chunk	+1 line, -1 line	1 comment	Download
	M	net/url_request/url_request_unittest.cc	View		2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

wtc

11 years, 4 months ago (2009-08-07 19:10:19 UTC) #2

LGTM.  The CL's description should also describe your
NotifyDone change to url_request_new_ftp_job.cc.

http://codereview.chromium.org/165142/diff/1/2
File net/url_request/url_request_new_ftp_job.cc (right):

http://codereview.chromium.org/165142/diff/1/2#newcode249
Line 249: NotifyDone(URLRequestStatus(URLRequestStatus::FAILED, result));
I verified that this is what the old URLRequestFtpJob does
if its Start() method fails.  It calls NotifyDone, via
URLRequestInetJob::ProcessRequestError().

It also calls NotifyHeadersComplete() if its Start() method
succeeds.

Expand Messages | Collapse Messages