Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1651403003: Modify skiaserve to support drawTo and /cmd/N (Closed)

Created:
4 years, 10 months ago by joshua.litt
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@skiaserve-9-fixcrash
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : tweak #

Patch Set 3 : handle /cmd #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -46 lines) Patch
M gyp/skiaserve.gyp View 1 chunk +15 lines, -3 lines 0 comments Download
M tools/skiaserve/skiaserve.cpp View 1 2 10 chunks +92 lines, -43 lines 1 comment Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
joshualitt
ptal
4 years, 10 months ago (2016-02-02 17:57:03 UTC) #3
jcgregorio
https://codereview.chromium.org/1651403003/diff/40001/tools/skiaserve/skiaserve.cpp File tools/skiaserve/skiaserve.cpp (right): https://codereview.chromium.org/1651403003/diff/40001/tools/skiaserve/skiaserve.cpp#newcode240 tools/skiaserve/skiaserve.cpp:240: SkStrSplit(url, "/", &commands); Need to split off the trailing ...
4 years, 10 months ago (2016-02-02 18:08:13 UTC) #4
joshualitt
On 2016/02/02 18:08:13, jcgregorio wrote: > https://codereview.chromium.org/1651403003/diff/40001/tools/skiaserve/skiaserve.cpp > File tools/skiaserve/skiaserve.cpp (right): > > https://codereview.chromium.org/1651403003/diff/40001/tools/skiaserve/skiaserve.cpp#newcode240 > ...
4 years, 10 months ago (2016-02-02 18:49:55 UTC) #5
jcgregorio
lgtm
4 years, 10 months ago (2016-02-02 18:51:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1651403003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1651403003/40001
4 years, 10 months ago (2016-02-02 18:51:49 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 19:07:46 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/136f517627556f9f831f92bc3e9e51c1ab9241d3

Powered by Google App Engine
This is Rietveld 408576698