Add metrics for calculating precision/recall of link navigation pre-connect triggers.

content/public/browser/resource_request_details.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_RESOURCE_REQUEST_DETAILS_H_
 #define CONTENT_PUBLIC_BROWSER_RESOURCE_REQUEST_DETAILS_H_
 
 #include <string>
 
+#include "content/public/common/page_transition_types.h"
 #include "googleurl/src/gurl.h"
 #include "net/cert/cert_status_flags.h"
 #include "net/base/host_port_pair.h"
 #include "net/url_request/url_request_status.h"
 #include "webkit/glue/resource_type.h"
 
 namespace net {
 class URLRequest;
 }
 
 namespace content {
 
 // The ResourceRequestDetails object contains additional details about a
 // resource request notification. It copies many of the publicly accessible
 // member variables of net::URLRequest, but exists on the UI thread.
 struct ResourceRequestDetails {
-  ResourceRequestDetails(const net::URLRequest* request, int cert_id);
+  ResourceRequestDetails(const net::URLRequest* request,
+                         int cert_id,
+                         PageTransition transition);
 
   virtual ~ResourceRequestDetails();
 
   GURL url;
   GURL original_url;
   std::string method;
   std::string referrer;
   bool has_upload;
   int load_flags;
   int origin_child_id;
   int origin_route_id;
   net::URLRequestStatus status;
   int ssl_cert_id;
   net::CertStatus ssl_cert_status;
   ResourceType::Type resource_type;
   net::HostPortPair socket_address;
   int64 frame_id;
+  PageTransition page_transition;
 };
 
 // Details about a redirection of a resource request.
 struct ResourceRedirectDetails : public ResourceRequestDetails {

[jar (doing other things), 2013/06/18 01:33:49]

nit: These should probably be classes.  By the time you have virtual methods, a
class seems much more appropriate.  

Any justification I'm missing?

Alternatively... why do we need this as a derived class (er...um... stuct)?

[kouhei (in TOK), 2013/06/18 22:28:41]

I'd like to address this in separate CL.

   ResourceRedirectDetails(const net::URLRequest* request,
                           int cert_id,
+                          PageTransition transition,
                           const GURL& new_url);
   virtual ~ResourceRedirectDetails();
 
   // The URL to which we are being redirected.
   GURL new_url;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_RESOURCE_REQUEST_DETAILS_H_