Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Side by Side Diff: third_party/WebKit/WebCore/platform/ThreadGlobalData.h

Issue 16514: Add TODO for TEC usage, which might be better controlled by USE(ICU_UNICODE)... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 ~ThreadGlobalData(); 43 ~ThreadGlobalData();
44 44
45 EventNames& eventNames(); 45 EventNames& eventNames();
46 StringImpl* emptyString() { return m_emptyString; } 46 StringImpl* emptyString() { return m_emptyString; }
47 HashSet<StringImpl*>& atomicStringTable() { return *m_atomicStringTable; } 47 HashSet<StringImpl*>& atomicStringTable() { return *m_atomicStringTable; }
48 48
49 #if USE(ICU_UNICODE) 49 #if USE(ICU_UNICODE)
50 ICUConverterWrapper& cachedConverterICU() { return *m_cachedConverterICU ; } 50 ICUConverterWrapper& cachedConverterICU() { return *m_cachedConverterICU ; }
51 #endif 51 #endif
52 52
53 // TODO(awalker): TEC isn't really a Darwin feature, so we should look at
54 // turning on USE(ICU_UNICODE) instead.
53 #if PLATFORM(DARWIN) 55 #if PLATFORM(DARWIN)
54 TECConverterWrapper& cachedConverterTEC() { return *m_cachedConverterTEC ; } 56 TECConverterWrapper& cachedConverterTEC() { return *m_cachedConverterTEC ; }
55 #endif 57 #endif
56 58
57 private: 59 private:
58 StringImpl* m_emptyString; 60 StringImpl* m_emptyString;
59 HashSet<StringImpl*>* m_atomicStringTable; 61 HashSet<StringImpl*>* m_atomicStringTable;
60 EventNames* m_eventNames; 62 EventNames* m_eventNames;
61 63
62 #if USE(ICU_UNICODE) 64 #if USE(ICU_UNICODE)
63 ICUConverterWrapper* m_cachedConverterICU; 65 ICUConverterWrapper* m_cachedConverterICU;
64 #endif 66 #endif
65 67
68 // TODO(awalker): TEC isn't really a Darwin feature, so we should look at
69 // turning on USE(ICU_UNICODE) instead.
66 #if PLATFORM(DARWIN) 70 #if PLATFORM(DARWIN)
67 TECConverterWrapper* m_cachedConverterTEC; 71 TECConverterWrapper* m_cachedConverterTEC;
68 #endif 72 #endif
69 }; 73 };
70 74
71 ThreadGlobalData& threadGlobalData(); 75 ThreadGlobalData& threadGlobalData();
72 76
73 } // namespace WebCore 77 } // namespace WebCore
74 78
75 #endif // ThreadGlobalData_h 79 #endif // ThreadGlobalData_h
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698