Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 1651323002: Revert of Adds bot_update to depot_tools. (Closed)

Created:
4 years, 10 months ago by luqui
Modified:
4 years, 10 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, estaab, iannucci+depot_tools_chromium.org, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of Adds bot_update to depot_tools. (patchset #8 id:140001 of https://codereview.chromium.org/1641363002/ ) Reason for revert: Exposed recipe engine bug with ambiguous names, causing roller blockage. Original issue's description: > Adds bot_update to depot_tools. > > This CL imports the bot_update script, along with the bot_update and gclient recipe modules from build. This should allow for recipes to run on swarming. > > Also moves the recipe stuff into the infra folder. > > bot_update has been modified. See full diff at https://paste.googleplex.com/4969207737352192 > > TBR=phajdan.jr@chromium.org > > BUG= > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298490 TBR=iannucci@chromium.org,phajdan.jr@chromium.org,martiniss@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298505

Patch Set 1 #

Patch Set 2 : Update .gitignore for safety #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3866 lines) Patch
M .gitignore View 1 1 chunk +1 line, -0 lines 0 comments Download
M infra/config/OWNERS View 1 1 chunk +0 lines, -1 line 0 comments Download
M infra/config/recipes.cfg View 1 chunk +1 line, -1 line 0 comments Download
D infra/recipe_modules/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D infra/recipe_modules/bot_update/__init__.py View 1 chunk +0 lines, -27 lines 0 comments Download
D infra/recipe_modules/bot_update/api.py View 1 chunk +0 lines, -280 lines 0 comments Download
D infra/recipe_modules/bot_update/example.py View 1 chunk +0 lines, -107 lines 0 comments Download
D infra/recipe_modules/bot_update/example.expected/basic.json View 1 chunk +0 lines, -46 lines 0 comments Download
D infra/recipe_modules/bot_update/example.expected/basic_output_manifest.json View 1 chunk +0 lines, -53 lines 0 comments Download
D infra/recipe_modules/bot_update/example.expected/basic_with_branch_heads.json View 1 chunk +0 lines, -47 lines 0 comments Download
D infra/recipe_modules/bot_update/example.expected/clobber.json View 1 chunk +0 lines, -47 lines 0 comments Download
D infra/recipe_modules/bot_update/example.expected/no_shallow.json View 1 chunk +0 lines, -47 lines 0 comments Download
D infra/recipe_modules/bot_update/example.expected/reset_root_solution_revision.json View 1 chunk +0 lines, -46 lines 0 comments Download
D infra/recipe_modules/bot_update/example.expected/trychange.json View 1 chunk +0 lines, -48 lines 0 comments Download
D infra/recipe_modules/bot_update/example.expected/trychange_oauth2.json View 1 chunk +0 lines, -50 lines 0 comments Download
D infra/recipe_modules/bot_update/example.expected/tryjob.json View 1 chunk +0 lines, -48 lines 0 comments Download
D infra/recipe_modules/bot_update/example.expected/tryjob_fail.json View 1 chunk +0 lines, -50 lines 0 comments Download
D infra/recipe_modules/bot_update/example.expected/tryjob_fail_patch.json View 1 chunk +0 lines, -72 lines 0 comments Download
D infra/recipe_modules/bot_update/example.expected/tryjob_fail_patch_download.json View 1 chunk +0 lines, -72 lines 0 comments Download
D infra/recipe_modules/bot_update/example.expected/tryjob_v8.json View 1 chunk +0 lines, -51 lines 0 comments Download
D infra/recipe_modules/bot_update/resources/bot_update.py View 1 chunk +0 lines, -1567 lines 0 comments Download
D infra/recipe_modules/bot_update/test_api.py View 1 chunk +0 lines, -74 lines 0 comments Download
D infra/recipe_modules/depot_tools/__init__.py View 1 chunk +0 lines, -1 line 0 comments Download
D infra/recipe_modules/gclient/__init__.py View 1 chunk +0 lines, -10 lines 0 comments Download
D infra/recipe_modules/gclient/api.py View 1 chunk +0 lines, -309 lines 0 comments Download
D infra/recipe_modules/gclient/config.py View 1 chunk +0 lines, -80 lines 0 comments Download
D infra/recipe_modules/gclient/example.py View 1 chunk +0 lines, -51 lines 0 comments Download
D infra/recipe_modules/gclient/example.expected/basic.json View 1 chunk +0 lines, -157 lines 0 comments Download
D infra/recipe_modules/gclient/example.expected/revision.json View 1 chunk +0 lines, -159 lines 0 comments Download
D infra/recipe_modules/gclient/example.expected/tryserver.json View 1 chunk +0 lines, -170 lines 0 comments Download
D infra/recipe_modules/gclient/test_api.py View 1 chunk +0 lines, -37 lines 0 comments Download
D infra/recipe_modules/hacky_tryserver_detection/__init__.py View 1 1 chunk +0 lines, -7 lines 0 comments Download
D infra/recipe_modules/hacky_tryserver_detection/api.py View 1 chunk +0 lines, -46 lines 0 comments Download
D infra/recipe_modules/hacky_tryserver_detection/example.py View 1 chunk +0 lines, -17 lines 0 comments Download
D infra/recipe_modules/hacky_tryserver_detection/example.expected/basic.json View 1 chunk +0 lines, -15 lines 0 comments Download
D infra/recipe_modules/rietveld/__init__.py View 1 chunk +0 lines, -4 lines 0 comments Download
D infra/recipe_modules/rietveld/api.py View 1 chunk +0 lines, -45 lines 0 comments Download
D infra/recipe_modules/rietveld/example.py View 1 chunk +0 lines, -16 lines 0 comments Download
D infra/recipe_modules/rietveld/example.expected/basic.json View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
luqui
Created Revert of Adds bot_update to depot_tools.
4 years, 10 months ago (2016-02-01 23:57:47 UTC) #1
martiniss
lgtm
4 years, 10 months ago (2016-02-02 00:13:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1651323002/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1651323002/300001
4 years, 10 months ago (2016-02-02 00:14:10 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 00:16:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:300001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298505

Powered by Google App Engine
This is Rietveld 408576698