Issue 16513: Experimental: begin using the register allocator for switch statements...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16513: Experimental: begin using the register allocator for switch statements... (Closed)

Created:
11 years, 11 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/toiger/

Visibility:
Public.

Description

Experimental: begin using the register allocator for switch statements but not fast-case ones. Committed: http://code.google.com/p/v8/source/detail?r=1029

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -39 lines)			Patch
M	src/codegen.cc	View	1	2 chunks	+7 lines, -6 lines	0 comments	Download
M	src/codegen-ia32.cc	View	1	5 chunks	+27 lines, -19 lines	2 comments	Download
M	src/virtual-frame-ia32.h	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	src/virtual-frame-ia32.cc	View	1	2 chunks	+4 lines, -8 lines	0 comments	Download
M	test/mjsunit/switch.js	View	1	4 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

William Hesse

LGTM http://codereview.chromium.org/16513/diff/401/406 File src/codegen-ia32.cc (right): http://codereview.chromium.org/16513/diff/401/406#newcode1823 Line 1823: // the frame. How about // Drop ...

11 years, 11 months ago (2009-01-06 13:37:02 UTC) #2

Kevin Millikin (Chromium)

11 years, 11 months ago (2009-01-06 14:18:47 UTC) #3

http://codereview.chromium.org/16513/diff/401/406
File src/codegen-ia32.cc (right):

http://codereview.chromium.org/16513/diff/401/406#newcode1823
Line 1823: // the frame.
On 2009/01/06 13:37:02, William Hesse wrote:
> How about 
> // Drop the switch value from the frame before entering the case body.

I want the comment to indicate that it only happens when entering from the test.
 I'll leave it for now, because it seems concise and accurate.

Expand Messages | Collapse Messages