Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Issue 165123003: Use chrome_constants rather than hardcoded Preferences string in startup_test.cc. (Closed)

Created:
6 years, 10 months ago by gab
Modified:
6 years, 10 months ago
Reviewers:
nduca
CC:
chromium-reviews, chrome-speed-team+watch_google.com
Visibility:
Public.

Description

Use chrome_constants rather than hardcoded Preferences string in startup_test.cc. R=nduca BUG=343692 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251506

Patch Set 1 #

Patch Set 2 : fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/test/perf/startup_test.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
gab
6 years, 10 months ago (2014-02-13 23:21:32 UTC) #1
nduca
lgtm if it helps
6 years, 10 months ago (2014-02-14 21:19:42 UTC) #2
gab
The CQ bit was checked by gab@chromium.org
6 years, 10 months ago (2014-02-14 21:20:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/165123003/60002
6 years, 10 months ago (2014-02-14 21:26:35 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-15 03:57:43 UTC) #5
Message was sent while issue was closed.
Change committed as 251506

Powered by Google App Engine
This is Rietveld 408576698