Issue 165123: On GTK, middle-click on the title bar (and the window frame in general) will...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 165123: On GTK, middle-click on the title bar (and the window frame in general) will... (Closed)

Created:
11 years, 4 months ago by Nigel Tao

Modified:
9 years, 7 months ago

Reviewers:
tony, calebegg, Evan Martin

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

On GTK, middle-click on the title bar (and the window frame in general) will lower the window. This is Chromium's custom titlebar, not the one provided by the window manager. BUG=15430

Patch Set 1 #

Total comments: 1

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	chrome/browser/gtk/browser_window_gtk.cc	View		2 chunks	+5 lines, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

CalebEgg_gmail.com

http://codereview.chromium.org/165123/diff/1/2 File chrome/browser/gtk/browser_window_gtk.cc (right): http://codereview.chromium.org/165123/diff/1/2#newcode1591 Line 1591: gdk_window_lower(GTK_WIDGET(browser->window_)->window); Won't this need to be wrapped in ...

11 years, 4 months ago (2009-08-07 09:09:38 UTC) #1

tony

I'm ok with this for now, so LGTM. It looks like in metacity, if you ...

11 years, 4 months ago (2009-08-07 18:48:30 UTC) #2

r22885

Expand Messages | Collapse Messages