Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 165123: On GTK, middle-click on the title bar (and the window frame in general) will... (Closed)

Created:
11 years, 4 months ago by Nigel Tao
Modified:
9 years, 7 months ago
Reviewers:
tony, calebegg, Evan Martin
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

On GTK, middle-click on the title bar (and the window frame in general) will lower the window. This is Chromium's custom titlebar, not the one provided by the window manager. BUG=15430

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/browser/gtk/browser_window_gtk.cc View 2 chunks +5 lines, -2 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
CalebEgg_gmail.com
http://codereview.chromium.org/165123/diff/1/2 File chrome/browser/gtk/browser_window_gtk.cc (right): http://codereview.chromium.org/165123/diff/1/2#newcode1591 Line 1591: gdk_window_lower(GTK_WIDGET(browser->window_)->window); Won't this need to be wrapped in ...
11 years, 4 months ago (2009-08-07 09:09:38 UTC) #1
tony
I'm ok with this for now, so LGTM. It looks like in metacity, if you ...
11 years, 4 months ago (2009-08-07 18:48:30 UTC) #2
Evan Martin
11 years, 4 months ago (2009-08-09 05:29:53 UTC) #3
r22885

Powered by Google App Engine
This is Rietveld 408576698