Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2349)

Unified Diff: ash/system/chromeos/network/network_connect.cc

Issue 16512003: Configure networks requiring a certificate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add localized Auth error messages Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/system/chromeos/network/network_connect.cc
diff --git a/ash/system/chromeos/network/network_connect.cc b/ash/system/chromeos/network/network_connect.cc
index 03c30be817189570e2f5cc9f98af91dcd2146930..144c9d0f8565a5761d3ae5aca4553c9bd3c4a8fb 100644
--- a/ash/system/chromeos/network/network_connect.cc
+++ b/ash/system/chromeos/network/network_connect.cc
@@ -47,12 +47,20 @@ void OnConnectFailed(const std::string& service_path,
service_path);
return;
}
+ // Shill does not always provide a helpful error. In this case, show the
+ // configure UI and a notification. See crbug.com/217033 for an example.
pneubeck (no reviews) 2013/06/06 20:41:20 "configure UI" -> "configuration UI" or "settings
stevenjb 2013/06/07 03:44:58 Done.
+ if (error_name == NetworkConnectionHandler::kErrorConnectFailed) {
+ ash::Shell::GetInstance()->system_tray_delegate()->ConfigureNetwork(
+ service_path);
+ }
ash::Shell::GetInstance()->system_tray_notifier()->network_state_notifier()->
ShowNetworkConnectError(error_name, service_path);
}
void OnConnectSucceeded(const std::string& service_path) {
VLOG(1) << "Connect Succeeded for " << service_path;
+ ash::Shell::GetInstance()->system_tray_notifier()->NotifyClearNetworkMessage(
+ NetworkObserver::ERROR_CONNECT_FAILED);
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698