Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1651193005: Fix heap-use-after-free in V8::Initialize() (Closed)

Created:
4 years, 10 months ago by jun_fang
Modified:
4 years, 10 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com, Jim Wang, kai_jing
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -46 lines) Patch
M fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp View 1 4 chunks +40 lines, -46 lines 1 comment Download

Messages

Total messages: 6 (2 generated)
jun_fang
Hi Tom and Lei, Please help to review this CL. Thanks!
4 years, 10 months ago (2016-02-02 11:55:18 UTC) #2
jun_fang
https://codereview.chromium.org/1651193005/diff/20001/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp File fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp (left): https://codereview.chromium.org/1651193005/diff/20001/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp#oldcode1137 fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp:1137: csContent = csContentC.GetPtr(); Here is the crashed point. FXSYS_wcslen ...
4 years, 10 months ago (2016-02-02 12:06:09 UTC) #3
Tom Sepez
lgtm
4 years, 10 months ago (2016-02-02 16:50:01 UTC) #4
jun_fang
4 years, 10 months ago (2016-02-03 01:35:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ef86dcd61c4b42d3787638e6ec5b96d4d7b4167b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698