Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 165117: Fix build break with uninitialized variable 'ev_policy_tag'.... (Closed)

Created:
11 years, 4 months ago by ukai
Modified:
9 years, 7 months ago
Reviewers:
wtc
CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, willchan no longer on Chromium
Visibility:
Public.

Description

Fix build break with uninitialized variable 'ev_policy_tag'. Fix some last nits in codereview.chromium.org/119026 TBR=wtc BUG=10911 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22720

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M net/base/x509_certificate_nss.cc View 5 chunks +9 lines, -10 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
ukai
11 years, 4 months ago (2009-08-07 04:18:10 UTC) #1
wtc
LGTM. http://codereview.chromium.org/165117/diff/1/2 File net/base/x509_certificate_nss.cc (left): http://codereview.chromium.org/165117/diff/1/2#oldcode604 Line 604: SECOidTag ev_policy_tag; Does the compiler warn about ...
11 years, 4 months ago (2009-08-07 18:07:48 UTC) #2
ukai
11 years, 4 months ago (2009-08-10 04:09:20 UTC) #3
http://codereview.chromium.org/165117/diff/1/2
File net/base/x509_certificate_nss.cc (left):

http://codereview.chromium.org/165117/diff/1/2#oldcode604
Line 604: SECOidTag ev_policy_tag;
On 2009/08/07 18:07:48, wtc wrote:
> Does the compiler warn about this?  We're passing
> &ev_policy_tag as an output parameter to
> GetEvPolicyOidTag, so ev_policy_tag doesn't need to be
> initialized.

Yes, it caused the build break.

Powered by Google App Engine
This is Rietveld 408576698