Issue 165117: Fix build break with uninitialized variable 'ev_policy_tag'....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 165117: Fix build break with uninitialized variable 'ev_policy_tag'.... (Closed)

Created:
11 years, 4 months ago by ukai

Modified:
9 years, 7 months ago

Reviewers:
wtc

CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, willchan no longer on Chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix build break with uninitialized variable 'ev_policy_tag'. Fix some last nits in codereview.chromium.org/119026 TBR=wtc BUG=10911 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22720

Patch Set 1 #

Total comments: 2

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -10 lines)			Patch
	M	net/base/x509_certificate_nss.cc	View		5 chunks	+9 lines, -10 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

wtc

LGTM. http://codereview.chromium.org/165117/diff/1/2 File net/base/x509_certificate_nss.cc (left): http://codereview.chromium.org/165117/diff/1/2#oldcode604 Line 604: SECOidTag ev_policy_tag; Does the compiler warn about ...

11 years, 4 months ago (2009-08-07 18:07:48 UTC) #2

ukai

11 years, 4 months ago (2009-08-10 04:09:20 UTC) #3

http://codereview.chromium.org/165117/diff/1/2
File net/base/x509_certificate_nss.cc (left):

http://codereview.chromium.org/165117/diff/1/2#oldcode604
Line 604: SECOidTag ev_policy_tag;
On 2009/08/07 18:07:48, wtc wrote:
> Does the compiler warn about this?  We're passing
> &ev_policy_tag as an output parameter to
> GetEvPolicyOidTag, so ev_policy_tag doesn't need to be
> initialized.

Yes, it caused the build break.

Expand Messages | Collapse Messages