src/IceAssemblerX86Base.h - Issue 1651163002: Subzero. Enables moar complex relocation offsets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceAssemblerX86Base.h

Issue 1651163002: Subzero. Enables moar complex relocation offsets. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Addresses comments. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceAssemblerX86Base.h

diff --git a/src/IceAssemblerX86Base.h b/src/IceAssemblerX86Base.h

index e76e0d161e616a3c54cd04161a10528bd3aeee8a..10871f45f6932f1b8dd3c362a1b9aba7caf46e3d 100644

--- a/src/IceAssemblerX86Base.h

+++ b/src/IceAssemblerX86Base.h

@@ -171,6 +171,7 @@ public:

Label *getOrCreateCfgNodeLabel(SizeT Number);

Label *getOrCreateLocalLabel(SizeT Number);

void bindLocalLabel(SizeT Number);

+ void bindRelocOffset(RelocOffset *Offset);

bool fixupIsPCRel(FixupKind Kind) const override {

// Currently assuming this is the only PC-rel relocation type used.

« no previous file with comments | « src/IceAssembler.h ('k') | src/IceAssemblerX86BaseImpl.h » ('j') | src/IceDefs.h » ('J')