src/IceInstX86BaseImpl.h - Issue 1651163002: Subzero. Enables moar complex relocation offsets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceInstX86BaseImpl.h

Issue 1651163002: Subzero. Enables moar complex relocation offsets. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: make format Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceInstX86BaseImpl.h

diff --git a/src/IceInstX86BaseImpl.h b/src/IceInstX86BaseImpl.h

index e9d3c8681650b20ac3e84e447a9b3515e33708fc..caa8cd1a8c5d230a69c744f6ddb05b6b193fe5c0 100644

--- a/src/IceInstX86BaseImpl.h

+++ b/src/IceInstX86BaseImpl.h

@@ -459,10 +459,10 @@ void InstImpl<TraitsType>::InstX86Label::emit(const Cfg *Func) const {

template <typename TraitsType>

void InstImpl<TraitsType>::InstX86Label::emitIAS(const Cfg *Func) const {

Assembler *Asm = Func->getAssembler<Assembler>();

- if (IsReturnLocation) {

- Asm->addRelocationAtCurrentPosition(getName(Func));

- }

Asm->bindLocalLabel(Number);

+ if (OffsetReloc != nullptr) {

+ Asm->bindRelocOffset(OffsetReloc);

+ }

}

template <typename TraitsType>

« no previous file with comments | « src/IceInstX86Base.h ('k') | src/IceOperand.h » ('j') | no next file with comments »