test/unittests/interpreter/bytecode-array-iterator-unittest.cc - Issue 1651133002: [interpreter] Move temporary register allocator into own file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/unittests/interpreter/bytecode-array-iterator-unittest.cc

Issue 1651133002: [interpreter] Move temporary register allocator into own file. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Incorporate review comments from rmcilroy. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « test/unittests/interpreter/bytecode-array-builder-unittest.cc ('k') | test/unittests/interpreter/bytecode-register-allocator-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/unittests/interpreter/bytecode-array-iterator-unittest.cc

diff --git a/test/unittests/interpreter/bytecode-array-iterator-unittest.cc b/test/unittests/interpreter/bytecode-array-iterator-unittest.cc

index cd9f120cada68185751793fd458da5bee9d09b28..657a7ddb6b732dd3c2a87bb84ab0aab2a08202c2 100644

--- a/test/unittests/interpreter/bytecode-array-iterator-unittest.cc

+++ b/test/unittests/interpreter/bytecode-array-iterator-unittest.cc

@@ -22,11 +22,7 @@ class BytecodeArrayIteratorTest : public TestWithIsolateAndZone {

TEST_F(BytecodeArrayIteratorTest, IteratesBytecodeArray) {

// Use a builder to create an array with containing multiple bytecodes

// with 0, 1 and 2 operands.

- BytecodeArrayBuilder builder(isolate(), zone());

- builder.set_parameter_count(3);

- builder.set_locals_count(2);

- builder.set_context_count(0);

+ BytecodeArrayBuilder builder(isolate(), zone(), 3, 2, 0);

Factory* factory = isolate()->factory();

Handle<HeapObject> heap_num_0 = factory->NewHeapNumber(2.718);

Handle<HeapObject> heap_num_1 = factory->NewHeapNumber(2147483647);