[interpreter] Move temporary register allocator into own file.

src/interpreter/bytecode-array-iterator.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/interpreter/bytecode-array-iterator.h"
 
 #include "src/objects-inl.h"
 
 namespace v8 {
 namespace internal {
@@ skipping 71 matching lines @@
   uint32_t operand = GetRawOperand(operand_index, operand_type);
   return static_cast<int>(operand);
 }
 
 
 Register BytecodeArrayIterator::GetRegisterOperand(int operand_index) const {
   OperandType operand_type =
       Bytecodes::GetOperandType(current_bytecode(), operand_index);
   DCHECK(Bytecodes::IsRegisterOperandType(operand_type));
   uint32_t operand = GetRawOperand(operand_index, operand_type);
+  Register reg;
   switch (Bytecodes::GetOperandSize(current_bytecode(), operand_index)) {
     case OperandSize::kByte:
-      return Register::FromOperand(static_cast<uint8_t>(operand));
+      reg = Register::FromOperand(static_cast<uint8_t>(operand));
+      break;
     case OperandSize::kShort:
-      return Register::FromWideOperand(static_cast<uint16_t>(operand));
+      reg = Register::FromWideOperand(static_cast<uint16_t>(operand));
+      break;
     case OperandSize::kNone:
       UNREACHABLE();
+      reg = Register::invalid_value();

[rmcilroy, 2016/02/02 10:53:28]

break;

[oth, 2016/02/02 11:20:24]

Done.

   }
-  return Register();
+  DCHECK_GE(reg.index(),
+            Register::FromParameterIndex(0, bytecode_array()->parameter_count())
+                .index());
+  DCHECK(reg.index() < bytecode_array()->register_count() ||
+         (reg.index() == 0 &&
+          (Bytecodes::GetOperandType(current_bytecode(), operand_index) ==
+               OperandType::kMaybeReg8 ||
+           Bytecodes::GetOperandType(current_bytecode(), operand_index) ==
+               OperandType::kMaybeReg16)));

[rmcilroy, 2016/02/02 10:53:28]

nit - could you pull out a helper for IsMaybeRegisterOperandType for this check?

[oth, 2016/02/02 11:20:24]

Done. Also IsRegisterCountOperandType used just below.

+  return reg;
 }
 
 int BytecodeArrayIterator::GetRegisterOperandRange(int operand_index) const {
   interpreter::OperandType operand_type =
       Bytecodes::GetOperandType(current_bytecode(), operand_index);
   DCHECK(Bytecodes::IsRegisterOperandType(operand_type));
   switch (operand_type) {
     case OperandType::kRegPair8:
     case OperandType::kRegPair16:
     case OperandType::kRegOutPair8:
@@ skipping 39 matching lines @@
     return current_offset() + smi->value();
   } else {
     UNREACHABLE();
     return kMinInt;
   }
 }
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8