Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Side by Side Diff: src/identity-map.cc

Issue 1651133002: [interpreter] Move temporary register allocator into own file. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Incorporate review comments from rmcilroy. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/identity-map.h ('k') | src/interpreter/bytecode-array-builder.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/identity-map.h" 5 #include "src/identity-map.h"
6 6
7 #include "src/heap/heap.h" 7 #include "src/heap/heap.h"
8 #include "src/heap/heap-inl.h" 8 #include "src/heap/heap-inl.h"
9 #include "src/zone-containers.h" 9 #include "src/zone-containers.h"
10 10
11 namespace v8 { 11 namespace v8 {
12 namespace internal { 12 namespace internal {
13 13
14 static const int kInitialIdentityMapSize = 4; 14 static const int kInitialIdentityMapSize = 4;
15 static const int kResizeFactor = 4; 15 static const int kResizeFactor = 4;
16 16
17 IdentityMapBase::~IdentityMapBase() { 17 IdentityMapBase::~IdentityMapBase() { Clear(); }
18 if (keys_) heap_->UnregisterStrongRoots(keys_); 18
19 void IdentityMapBase::Clear() {
20 if (keys_) {
21 heap_->UnregisterStrongRoots(keys_);
22 keys_ = nullptr;
23 values_ = nullptr;
24 size_ = 0;
25 mask_ = 0;
26 }
19 } 27 }
20 28
21
22 IdentityMapBase::RawEntry IdentityMapBase::Lookup(Object* key) { 29 IdentityMapBase::RawEntry IdentityMapBase::Lookup(Object* key) {
23 int index = LookupIndex(key); 30 int index = LookupIndex(key);
24 return index >= 0 ? &values_[index] : nullptr; 31 return index >= 0 ? &values_[index] : nullptr;
25 } 32 }
26 33
27 34
28 IdentityMapBase::RawEntry IdentityMapBase::Insert(Object* key) { 35 IdentityMapBase::RawEntry IdentityMapBase::Insert(Object* key) {
29 int index = InsertIndex(key); 36 int index = InsertIndex(key);
30 DCHECK_GE(index, 0); 37 DCHECK_GE(index, 0);
31 return &values_[index]; 38 return &values_[index];
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 DCHECK_GE(index, 0); 188 DCHECK_GE(index, 0);
182 values_[index] = old_values[i]; 189 values_[index] = old_values[i];
183 } 190 }
184 191
185 // Unregister old keys and register new keys. 192 // Unregister old keys and register new keys.
186 heap_->UnregisterStrongRoots(old_keys); 193 heap_->UnregisterStrongRoots(old_keys);
187 heap_->RegisterStrongRoots(keys_, keys_ + size_); 194 heap_->RegisterStrongRoots(keys_, keys_ + size_);
188 } 195 }
189 } // namespace internal 196 } // namespace internal
190 } // namespace v8 197 } // namespace v8
OLDNEW
« no previous file with comments | « src/identity-map.h ('k') | src/interpreter/bytecode-array-builder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698