Chromium Code Reviews

Issue 1651113002: Use ElapsedTimer to measure VS files generation time in GN (Closed)

Created:
4 years, 10 months ago by Tomasz Moniuszko
Modified:
4 years, 10 months ago
Reviewers:
tfarina, brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ElapsedTimer to measure VS files generation time in GN BUG=305761 Committed: https://crrev.com/7515aa7db3baae8391162069a8e0af0fbf8d9ade Cr-Commit-Position: refs/heads/master@{#372912}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+4 lines, -6 lines)
M tools/gn/command_gen.cc View 1 chunk +4 lines, -6 lines 0 comments

Messages

Total messages: 9 (3 generated)
Tomasz Moniuszko
4 years, 10 months ago (2016-02-01 13:50:17 UTC) #2
brettw
lgtm
4 years, 10 months ago (2016-02-01 19:09:22 UTC) #3
tfarina
Thank you! lgtm
4 years, 10 months ago (2016-02-02 00:24:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1651113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1651113002/1
4 years, 10 months ago (2016-02-02 08:11:14 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-02 08:39:19 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 08:40:50 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7515aa7db3baae8391162069a8e0af0fbf8d9ade
Cr-Commit-Position: refs/heads/master@{#372912}

Powered by Google App Engine