Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1651103003: Componentize IDS_SECURE_CONNECTION_EV. (Closed)

Created:
4 years, 10 months ago by sdefresne
Modified:
4 years, 10 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Componentize IDS_SECURE_CONNECTION_EV. This string is used by ToolbarModelImpl which we want to share on iOS, so componentize it. BUG=582921 Committed: https://crrev.com/fbab68415cdb5061c63f3d325c7a3b13230315bf Cr-Commit-Position: refs/heads/master@{#373504}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M chrome/app/generated_resources.grd View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_model_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/omnibox_strings.grdp View 1 chunk +3 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1652153003 Patch 40001
Issue 1652153003 Patch 60001

Messages

Total messages: 9 (4 generated)
sdefresne
Please take a look.
4 years, 10 months ago (2016-02-01 17:26:30 UTC) #2
Peter Kasting
LGTM
4 years, 10 months ago (2016-02-02 23:39:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1651103003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1651103003/40001
4 years, 10 months ago (2016-02-04 09:54:51 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-04 10:54:05 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 10:55:12 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/fbab68415cdb5061c63f3d325c7a3b13230315bf
Cr-Commit-Position: refs/heads/master@{#373504}

Powered by Google App Engine
This is Rietveld 408576698