Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 16511004: Revert 205184 "Revert 204057 "Recurse to a maximum depth of 10 i..." (Closed)

Created:
7 years, 6 months ago by not at google - send to devlin
Modified:
7 years, 6 months ago
Reviewers:
marja
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 205184 "Revert 204057 "Recurse to a maximum depth of 10 i..." > Revert 204057 "Recurse to a maximum depth of 10 in v8_value_conv..." > > The commit caused crbug.com/248019. > > > Recurse to a maximum depth of 10 in v8_value_converter_impl.cc. There are > > objects that get passed in (canonically <input> elements apparently) which > > recurse infinitely (as opposed to having a self-referential loop). > > > > The previous solution to this problem (r150035) was to disable getters, which > > apparently were the main cause, but this is no longer appropriate - we now use > > this mechanism for all extension messaging, and this has become a problem (see > > bug 246213). > > > > TBR=jamesr@chromium.org, mpcomplete@chromium.org > > > > BUG=246213, 139933 > > > > Review URL: https://codereview.chromium.org/16295013 > > TBR=kalman@chromium.org > > Review URL: https://codereview.chromium.org/16733002 TBR=marja@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205209

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -98 lines) Patch
M trunk/src/chrome/test/data/extensions/api_test/executescript/callback/test.js View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/renderer/v8_value_converter_impl.h View 3 chunks +5 lines, -12 lines 0 comments Download
M trunk/src/content/renderer/v8_value_converter_impl.cc View 14 chunks +90 lines, -42 lines 0 comments Download
M trunk/src/content/renderer/v8_value_converter_impl_unittest.cc View 2 chunks +36 lines, -43 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
not at google - send to devlin
7 years, 6 months ago (2013-06-10 14:19:52 UTC) #1
not at google - send to devlin
7 years, 6 months ago (2013-06-10 14:20:44 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r205209.

Powered by Google App Engine
This is Rietveld 408576698