Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 1651073002: [regexp] do not store flags as bitfield in the parser. (Closed)

Created:
4 years, 10 months ago by Yang
Modified:
4 years, 10 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] do not store flags as bitfield in the parser. This reverts a small part of e709aa24c0 in an attempt to recover lost page_cycler performance. R=jkummerow@chromium.org BUG=chromium:580973 LOG=N Committed: https://crrev.com/ca6587c00709ce5a214bca0f9a33695b74ce268c Cr-Commit-Position: refs/heads/master@{#33637}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -20 lines) Patch
M src/regexp/regexp-parser.h View 5 chunks +14 lines, -10 lines 0 comments Download
M src/regexp/regexp-parser.cc View 5 chunks +11 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Yang
4 years, 10 months ago (2016-02-01 10:07:47 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1651073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1651073002/1
4 years, 10 months ago (2016-02-01 10:12:45 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-01 10:33:22 UTC) #5
Jakob Kummerow
lgtm
4 years, 10 months ago (2016-02-01 10:53:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1651073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1651073002/1
4 years, 10 months ago (2016-02-01 10:54:04 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-01 10:55:38 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 10:56:01 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca6587c00709ce5a214bca0f9a33695b74ce268c
Cr-Commit-Position: refs/heads/master@{#33637}

Powered by Google App Engine
This is Rietveld 408576698