Issue 165107: NNTP: Add a menu item that allows the user to restore all blacklisted...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 165107: NNTP: Add a menu item that allows the user to restore all blacklisted... (Closed)

Created:
11 years, 4 months ago by arv (Not doing code reviews)

Modified:
9 years, 4 months ago

Reviewers:
Miranda Callahan

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google), Glen Murphy

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

NNTP: Add a menu item that allows the user to restore all blacklisted thumbnails BUG=15247 TEST=Blacklist (remove) a few thumbnails (hit the x on the thumbnail toolbar). Then go to the options menu and "Restore all removed thumbnails". The removed thumbnails should be back. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22704

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -22 lines)			Patch
M	chrome/browser/resources/new_new_tab.css	View		2 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/browser/resources/new_new_tab.html	View	1 2	1 chunk	+10 lines, -6 lines	0 comments	Download
M	chrome/browser/resources/new_new_tab.js	View	1 2 3 4	4 chunks	+35 lines, -15 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Miranda Callahan

Awesome. LGTM. On 2009/08/07 00:14:31, arv wrote: >

11 years, 4 months ago (2009-08-07 00:17:52 UTC) #2

arv (Not doing code reviews)

I found a bug in updateOptionMenu. I refactored the command handling slightly. PTAL

11 years, 4 months ago (2009-08-07 00:33:08 UTC) #3

Miranda Callahan

11 years, 4 months ago (2009-08-07 00:39:09 UTC) #4

That's nicer than trying to figure out what "HR" stood for.  LG.

On 2009/08/07 00:33:08, arv wrote:
> I found a bug in updateOptionMenu. I refactored the command handling slightly.
> 
> PTAL

Expand Messages | Collapse Messages