sdk/lib/_internal/compiler/implementation/ssa/nodes.dart - Issue 16510003: Make [HTypeConversion] with NO_CHECK code motion invariant to ensure no code is generated for it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

Issue 16510003: Make [HTypeConversion] with NO_CHECK code motion invariant to ensure no code is generated for it. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/ssa/nodes.dart (revision 23847)

+++ sdk/lib/_internal/compiler/implementation/ssa/nodes.dart (working copy)

@@ -2291,6 +2291,7 @@

int typeCode() => HInstruction.TYPE_CONVERSION_TYPECODE;

bool typeEquals(HInstruction other) => other is HTypeConversion;

+ bool isCodeMotionInvariant() => kind == NO_CHECK;

bool dataEquals(HTypeConversion other) {

return kind == other.kind

« no previous file with comments | « no previous file | tests/compiler/dart2js/generate_at_use_site_test.dart » ('j') | no next file with comments »