chrome/browser/extensions/activity_log/activity_actions.h - Issue 16510002: Better ActivityLog error handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/activity_log/activity_actions.h

Issue 16510002: Better ActivityLog error handling (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Cleanup before review Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/activity_log/activity_actions.h

diff --git a/chrome/browser/extensions/activity_log/activity_actions.h b/chrome/browser/extensions/activity_log/activity_actions.h

index 547d2d8bb60c540da9737be0329b8bc0f45bb4ea..5e2cbd53db712d0463746b2a0c85cffbcbf61f23 100644

--- a/chrome/browser/extensions/activity_log/activity_actions.h

+++ b/chrome/browser/extensions/activity_log/activity_actions.h

@@ -26,7 +26,7 @@ class Action : public base::RefCountedThreadSafe<Action> {

static bool InitializeTableInternal(sql::Connection* db);

// Record the action in the database.

- virtual void Record(sql::Connection* db) = 0;

+ virtual bool Record(sql::Connection* db) = 0;

// Flatten the activity's type-specific fields into an ExtensionActivity.

virtual scoped_ptr<api::activity_log_private::ExtensionActivity>