Allow blocking git-cache update with a timeout.

Allow blocking git-cache update with a timeout.

I guess I'm the only developer using git-cache, which is sad.
Hopefully these fixes will make it easier to adapt this to developer
usage some time in the FUTURE.

BUG=583420
TEST=Works for me
R=agable@chromium.org,tandrii@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298531

[tandrii(chromium), 2016-02-02 22:01:00]

LGTM % i'm not sure I can fully contemplate the implications of this. I'd prefer
you get iannucci@ or agable@ approval as well, though you clearly know more than
me already :)

And of course trooper should be notified before landing.

https://codereview.chromium.org/1650993005/diff/1/git_cache.py
File git_cache.py (right):

https://codereview.chromium.org/1650993005/diff/1/git_cache.py#newcode106
git_cache.py:106: elapsed += sleep_time
maybe also print here that it's waiting on a lock?

[szager1, 2016-02-02 22:33:11]

https://codereview.chromium.org/1650993005/diff/1/git_cache.py
File git_cache.py (right):

https://codereview.chromium.org/1650993005/diff/1/git_cache.py#newcode106
git_cache.py:106: elapsed += sleep_time
On 2016/02/02 22:01:00, tandrii(chromium) wrote:
> maybe also print here that it's waiting on a lock?

Done.

[tandrii(chromium), 2016-02-02 22:49:10]

LGTM % "thanks, but" :)

https://codereview.chromium.org/1650993005/diff/40001/git_cache.py
File git_cache.py (right):

https://codereview.chromium.org/1650993005/diff/40001/git_cache.py#newcode106
git_cache.py:106: 'will retry after sleep(3).');
well, if so then why not sleep(%d).', sleep_time?

[szager1, 2016-02-02 22:52:59]

https://codereview.chromium.org/1650993005/diff/40001/git_cache.py
File git_cache.py (right):

https://codereview.chromium.org/1650993005/diff/40001/git_cache.py#newcode106
git_cache.py:106: 'will retry after sleep(3).');
On 2016/02/02 22:49:10, tandrii(chromium) wrote:
> well, if so then why not sleep(%d).', sleep_time?

Done.

[szager1, 2016-02-02 22:53:52]

Description was changed from

==========
Allow blocking git-cache update with a timeout.

I guess I'm the only developer using git-cache, which is sad.
Hopefully these fixes will make it easier to adapt this to developer
usage some time in the FUTURE.

BUG=583420
TEST=Works for me
R=agable@chromium.org,tandrii@chromium.org
==========

to

==========
Allow blocking git-cache update with a timeout.

I guess I'm the only developer using git-cache, which is sad.
Hopefully these fixes will make it easier to adapt this to developer
usage some time in the FUTURE.

BUG=583420
TEST=Works for me
R=agable@chromium.org,tandrii@chromium.org
==========

[szager1, 2016-02-02 22:56:18]

The CQ bit was checked by szager@chromium.org

[szager1, 2016-02-02 22:56:19]

The patchset sent to the CQ was uploaded after l-g-t-m from tandrii@chromium.org
Link to the patchset: https://codereview.chromium.org/1650993005/#ps60001
(title: "nit")

[commit-bot: I haz the power, 2016-02-02 22:56:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1650993005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1650993005/60001

[agable, 2016-02-02 22:58:04]

lgtm

[commit-bot: I haz the power, 2016-02-02 22:59:31]

Description was changed from

==========
Allow blocking git-cache update with a timeout.

I guess I'm the only developer using git-cache, which is sad.
Hopefully these fixes will make it easier to adapt this to developer
usage some time in the FUTURE.

BUG=583420
TEST=Works for me
R=agable@chromium.org,tandrii@chromium.org
==========

to

==========
Allow blocking git-cache update with a timeout.

I guess I'm the only developer using git-cache, which is sad.
Hopefully these fixes will make it easier to adapt this to developer
usage some time in the FUTURE.

BUG=583420
TEST=Works for me
R=agable@chromium.org,tandrii@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298531
==========

[commit-bot: I haz the power, 2016-02-02 22:59:32]

Committed patchset #4 (id:60001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298531