Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4405)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/importer/firefox2_importer.cc

Issue 165094: Fix Issue 18530.... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/importer/firefox2_importer.cc
===================================================================
--- chrome/browser/importer/firefox2_importer.cc (revision 22618)
+++ chrome/browser/importer/firefox2_importer.cc (working copy)
@@ -75,13 +75,10 @@
// static
void Firefox2Importer::LoadDefaultBookmarks(const std::wstring& app_path,
std::set<GURL> *urls) {
- // TODO(port): Code below is correct only on Windows.
- // Firefox keeps its default bookmarks in a bookmarks.html file that
- // lives at: <Firefox install dir>\defaults\profile\bookmarks.html
FilePath file = FilePath::FromWStringHack(app_path);
- file.AppendASCII("defaults");
- file.AppendASCII("profile");
- file.AppendASCII("bookmarks.html");
+ file = file.AppendASCII("defaults");
+ file = file.AppendASCII("profile");
+ file = file.AppendASCII("bookmarks.html");
urls->clear();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698