Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 1650923002: Revert of Make opening a new tab with the NTP use PAGE_TRANSITION_AUTO_TOPLEVEL. (Closed)

Created:
4 years, 10 months ago by calamity
Modified:
4 years, 10 months ago
Reviewers:
msw
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make opening a new tab with the NTP use PAGE_TRANSITION_AUTO_TOPLEVEL. (patchset #1 id:1 of https://codereview.chromium.org/1397673004/ ) Reason for revert: This CL breaks the tab focus stack for new tabs. This patch should account for this and add a test for the existing behavior. Original issue's description: > Make opening a new tab with the NTP use PAGE_TRANSITION_AUTO_TOPLEVEL. > > This CL changes the page transition type for opening the NTP from > PAGE_TRANSITION_TYPED to PAGE_TRANSITION_AUTO_TOPLEVEL. Semantically, > this makes sense because the new tab is content automatically loaded > into a top level frame and the user did not 'type' chrome://newtab. > > This change was made to distinguish between actual direct URL navigations > and opening a new tab when considering whether the Site Engagement Service > should award the origin engagement points. > > BUG=543358 > > Committed: https://crrev.com/d0cdbbbf6653a1ff04dba51558d582035555992b > Cr-Commit-Position: refs/heads/master@{#354404} TBR=msw@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=543358, 582249 Committed: https://crrev.com/272612bfdd61b7d32a679c3ab54a72c8f26be3c5 Cr-Commit-Position: refs/heads/master@{#372583}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M chrome/browser/ui/browser_tabstrip.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
calamity
Created Revert of Make opening a new tab with the NTP use PAGE_TRANSITION_AUTO_TOPLEVEL.
4 years, 10 months ago (2016-01-31 23:59:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1650923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1650923002/1
4 years, 10 months ago (2016-02-01 00:00:30 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-01 00:40:14 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 00:41:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/272612bfdd61b7d32a679c3ab54a72c8f26be3c5
Cr-Commit-Position: refs/heads/master@{#372583}

Powered by Google App Engine
This is Rietveld 408576698