DescriptionRevert of Make opening a new tab with the NTP use PAGE_TRANSITION_AUTO_TOPLEVEL. (patchset #1 id:1 of https://codereview.chromium.org/1397673004/ )
Reason for revert:
This CL breaks the tab focus stack for new tabs. This patch should account for this and add a test for the existing behavior.
Original issue's description:
> Make opening a new tab with the NTP use PAGE_TRANSITION_AUTO_TOPLEVEL.
>
> This CL changes the page transition type for opening the NTP from
> PAGE_TRANSITION_TYPED to PAGE_TRANSITION_AUTO_TOPLEVEL. Semantically,
> this makes sense because the new tab is content automatically loaded
> into a top level frame and the user did not 'type' chrome://newtab.
>
> This change was made to distinguish between actual direct URL navigations
> and opening a new tab when considering whether the Site Engagement Service
> should award the origin engagement points.
>
> BUG=543358
>
> Committed: https://crrev.com/d0cdbbbf6653a1ff04dba51558d582035555992b
> Cr-Commit-Position: refs/heads/master@{#354404}
TBR=msw@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=543358, 582249
Committed: https://crrev.com/272612bfdd61b7d32a679c3ab54a72c8f26be3c5
Cr-Commit-Position: refs/heads/master@{#372583}
Patch Set 1 #
Messages
Total messages: 8 (4 generated)
|