Enable new FTP for Windows TestShell so that the results of block-test.html a...

Enable new FTP for Windows TestShell so that the results of block-test.html are
the same across platforms.  WTC tells me that it should be ready to go, and it
anyways is only exercised by these two security/block-test*.html tests.

Also, add back the fix from r22651.

Extend that fix a bit so that when we do not have a special mapping, we just spit out the existing error code value.  This way, if we get an unexpected result, the output will tell us what the original error code was.  This change doesn't impact any layout tests.

R=dglazkov,wtc
BUG=18665
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22686

[darin (slow to review), 2009-08-06 22:11:26]

wtc: you only need to review the change to test_shell_request_context.cc, which
enables new ftp for test_shell.

dglazkov: if you could review the rest, that would be great.

[dglazkov, 2009-08-06 22:38:59]

LGTM!

[wtc, 2009-08-06 22:40:55]

LGTM on my part.  But more code can be removed.

http://codereview.chromium.org/165091/diff/11/1010
File webkit/tools/test_shell/test_shell_request_context.cc (left):

http://codereview.chromium.org/165091/diff/11/1010#oldcode64
Line 64: if (CommandLine::ForCurrentProcess()->HasSwitch(test_shell::kNewFtp))
Please also remove the test_shell command-line switch
kNewFtp from test_shell_switches.{cc,h}.

http://codereview.chromium.org/165091/diff/11/1010
File webkit/tools/test_shell/test_shell_request_context.cc (right):

http://codereview.chromium.org/165091/diff/11/1010#newcode7
Line 7: #include "base/command_line.h"
See if you can remove this and
"webkit/tools/test_shell/test_shell_switches.h".

I added them for the
CommandLine::ForCurrentProcess()->HasSwitch(test_shell::kNewFtp)
call below.

[darin (slow to review), 2009-08-06 22:44:51]

Good catch, Wan-Teh!-Darin

On Thu, Aug 6, 2009 at 3:40 PM, <wtc@chromium.org> wrote:

> LGTM on my part.  But more code can be removed.
>
>
> http://codereview.chromium.org/165091/diff/11/1010
> File webkit/tools/test_shell/test_shell_request_context.cc (left):
>
> http://codereview.chromium.org/165091/diff/11/1010#oldcode64
> Line 64: if
> (CommandLine::ForCurrentProcess()->HasSwitch(test_shell::kNewFtp))
> Please also remove the test_shell command-line switch
> kNewFtp from test_shell_switches.{cc,h}.
>
> http://codereview.chromium.org/165091/diff/11/1010
> File webkit/tools/test_shell/test_shell_request_context.cc (right):
>
> http://codereview.chromium.org/165091/diff/11/1010#newcode7
> Line 7: #include "base/command_line.h"
> See if you can remove this and
> "webkit/tools/test_shell/test_shell_switches.h".
>
> I added them for the
> CommandLine::ForCurrentProcess()->HasSwitch(test_shell::kNewFtp)
> call below.
>
>
> http://codereview.chromium.org/165091
>