Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Unified Diff: tools/rebaseline.py

Issue 16509006: rebaseline.py: improve readability of dry-run output (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/tests/rebaseline/output/all/output-expected/stdout » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/rebaseline.py
===================================================================
--- tools/rebaseline.py (revision 9506)
+++ tools/rebaseline.py (working copy)
@@ -159,6 +159,9 @@
# results (those for which we don't have any expectations yet)
# should be rebaselined. For now, we only return failed expectations.
def _GetFilesToRebaseline(self, json_url):
+ if self._dry_run:
+ print ''
+ print '#'
print ('# Getting files to rebaseline from JSON summary URL %s ...'
% json_url)
try:
@@ -180,11 +183,15 @@
files_to_rebaseline.extend(failed_results.keys())
print '# ... found files_to_rebaseline %s' % files_to_rebaseline
+ if self._dry_run:
+ print '#'
return files_to_rebaseline
# Rebaseline a single file.
def _RebaselineOneFile(self, expectations_subdir, builder_name,
infilename, outfilename):
+ if self._dry_run:
+ print ''
print '# ' + infilename
url = ('http://skia-autogen.googlecode.com/svn/gm-actual/' +
expectations_subdir + '/' + builder_name + '/' +
@@ -234,6 +241,8 @@
else:
configs = [ '565', '8888', 'gpu', 'pdf', 'mesa', 'msaa16',
'msaa4' ]
+ if self._dry_run:
+ print ''
print '# ' + expectations_subdir + ':'
for config in configs:
infilename = test + '_' + config + '.png'
« no previous file with comments | « no previous file | tools/tests/rebaseline/output/all/output-expected/stdout » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698