Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Side by Side Diff: src/lithium-allocator.cc

Issue 16509004: Add missing AllowHandleDereference to LAllocator::BuildLiveRanges. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1330 matching lines...) Expand 10 before | Expand all | Expand 10 after
1341 BitVector::Iterator iterator(live); 1341 BitVector::Iterator iterator(live);
1342 bool found = false; 1342 bool found = false;
1343 while (!iterator.Done()) { 1343 while (!iterator.Done()) {
1344 found = true; 1344 found = true;
1345 int operand_index = iterator.Current(); 1345 int operand_index = iterator.Current();
1346 if (chunk_->info()->IsStub()) { 1346 if (chunk_->info()->IsStub()) {
1347 CodeStub::Major major_key = chunk_->info()->code_stub()->MajorKey(); 1347 CodeStub::Major major_key = chunk_->info()->code_stub()->MajorKey();
1348 PrintF("Function: %s\n", CodeStub::MajorName(major_key, false)); 1348 PrintF("Function: %s\n", CodeStub::MajorName(major_key, false));
1349 } else { 1349 } else {
1350 ASSERT(chunk_->info()->IsOptimizing()); 1350 ASSERT(chunk_->info()->IsOptimizing());
1351 AllowHandleDereference allow_deref;
1351 PrintF("Function: %s\n", 1352 PrintF("Function: %s\n",
1352 *chunk_->info()->function()->debug_name()->ToCString()); 1353 *chunk_->info()->function()->debug_name()->ToCString());
1353 } 1354 }
1354 PrintF("Value %d used before first definition!\n", operand_index); 1355 PrintF("Value %d used before first definition!\n", operand_index);
1355 LiveRange* range = LiveRangeFor(operand_index); 1356 LiveRange* range = LiveRangeFor(operand_index);
1356 PrintF("First use is at %d\n", range->first_pos()->pos().Value()); 1357 PrintF("First use is at %d\n", range->first_pos()->pos().Value());
1357 iterator.Advance(); 1358 iterator.Advance();
1358 } 1359 }
1359 ASSERT(!found); 1360 ASSERT(!found);
1360 } 1361 }
(...skipping 824 matching lines...) Expand 10 before | Expand all | Expand 10 after
2185 LiveRange* current = live_ranges()->at(i); 2186 LiveRange* current = live_ranges()->at(i);
2186 if (current != NULL) current->Verify(); 2187 if (current != NULL) current->Verify();
2187 } 2188 }
2188 } 2189 }
2189 2190
2190 2191
2191 #endif 2192 #endif
2192 2193
2193 2194
2194 } } // namespace v8::internal 2195 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698