pkg/analyzer/lib/src/context/context.dart - Issue 1650873002: Fix memory leak in incremental resolver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/context/context.dart

Issue 1650873002: Fix memory leak in incremental resolver (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: simplify and improve tests Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/lib/src/context/context.dart

diff --git a/pkg/analyzer/lib/src/context/context.dart b/pkg/analyzer/lib/src/context/context.dart

index 09c35ac064aad0049bcc210c7d98a1641d2bd1cd..d0d131d7aefdd2ebaebffde91fd9e59ced2c876a 100644

--- a/pkg/analyzer/lib/src/context/context.dart

+++ b/pkg/analyzer/lib/src/context/context.dart

@@ -1875,6 +1875,7 @@ class AnalysisContextImpl implements InternalAnalysisContext {

PoorMansIncrementalResolver resolver = new PoorMansIncrementalResolver(

typeProvider,

unitSource,

+ _cache,

sourceEntry,

unitEntry,

oldUnit,