g++ 4.3.x doesn't seem to like forward declarations...

g++ 4.3.x doesn't seem to like forward declarations
with namespace::classname so declare the forward
declaration inside the appropriate namespace.

[Craig Schlenter, 2009-01-03 09:38:19]

See http://code.google.com/p/chromium/issues/detail?id=3092 for similar issues
in the past that were fixed by just removing the forward declaration so this
should be safe but I have only tested on linux with g++ 4.3.x

[Paweł Hajdan Jr., 2009-01-03 10:30:44]

LGTM. Passed try server compile test.

[Paweł Hajdan Jr., 2009-01-03 10:50:39]

Wait, it's not so good. Sorry. We actually refer to base::SharedMemory in this
header.

The proper way to do it would be:

namespace base {
class SharedMemory;
}

[Craig Schlenter, 2009-01-03 12:58:25]

> The proper way to do it would be:
> 
> namespace base {
> class SharedMemory;
> }

OK, I tend to agree but it is different to how SkiaUtils.h was fixed in rev
3118. I've uploaded a new patch that does that and changed the comment. Lint is
unhappy with the change but I think it's ignorable.

[Paweł Hajdan Jr., 2009-01-03 14:54:58]

Thanks. Commited (r7539). I changed the indentation slightly.

[Dean McNamee, 2009-01-03 15:56:08]

LGTM

On 2009/01/03 14:54:58, Paweł Hajdan Jr. wrote:
> Thanks. Commited (r7539). I changed the indentation slightly.